[pull] main from livekit:main - #475
Merged
Merged
Conversation
Importing utils for a promise costs 497 packages: codec.go reaches pion/webrtc and 74 packages behind it, and the rest of utils pulls in psrpc and nats. A consumer whose only use is *utils.Promise on one interface method inherits all of it, and where that consumer is translated for deterministic simulation, so is every package in the closure. utils/promise and utils/deepcopy carry nothing beyond the standard library: context and sync, and reflect. Their constructors drop the stutter, and NewResolved is spelled apart from the Resolved method, which reports whether a promise has settled rather than producing one that has. The old spellings stay. Promise is a type alias rather than a defined type, so a promise built under either name satisfies an interface written against the other — the case that matters when one package declares the seam and another implements it. A compile-time assertion pins that, since a defined type would still build here and break only the callers that mix the two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )