Repository navigation
Conversation
Client.Request turned any status >= 400 into an error built from the status line and never read the body, so the structured error the Equinix APIs return (error code, message, field details) never reached the user. Include the trimmed body in the error when there is one. Refs equinix#88 Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part 2 of #88.
Client.RequestreturnedAPI error: <status>for any status >= 400 without reading the body, so the error the Equinix APIs send back (error code, message, per-field details) was dropped:Now the trimmed body is appended when the response has one; an empty body gives the same message as before:
The other part of #88 (
--formatvalidation) is a separate PR touching onlycmd/.Test
TestRequestKeepsErrorBodyininternal/api/api_test.gopoints aClientat anhttptestserver: a 404 with a JSON error body, and a 502 with no body.