Repository navigation
Conversation
The output switch only handled json and yaml, so any other --format made the request, printed a blank line and exited 0. Validate the flag in PreRunE so the command fails with a usage error naming the supported values, without calling the API. Refs equinix#88 Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part 1 of #88:
equinix api --format <anything but json|yaml>made the request, matched no case in the output switch and printed a bare newline with exit 0, so a typo looked like an empty API response.The flag is now checked in
PreRunE, before the client is built or any request is sent:Part 2 of #88 (error bodies dropped on 4xx/5xx) is in
internal/apiand goes in a separate PR, as suggested in the issue.Test
TestE2E_APIRejectsUnknownFormat(incmd/api_output_test.go) runs the real command against a fake API that returns JSON, and checks the error and that no request was made. It resets the package-levelformatflag int.Cleanupso later tests still get thejsondefault.No flag or help text changes, so no docs regeneration.