Skip to content

Remove Dependency Review workflow (switching from GHAS to Snyk) - #1100

Open
haritamar wants to merge 1 commit into
masterfrom
core-1693-remove-dependency-review-github-action
Open

haritamar wants to merge 1 commit into
masterfrom
core-1693-remove-dependency-review-github-action

Conversation

@haritamar

@haritamar haritamar commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

We're switching from GitHub Advanced Security to Snyk, so this PR removes the Dependency Review workflow (actions/dependency-review-action) and its config, .github/dependency-review-config.yml. The config also held the license allow-list and fail-on-severity: high.

Same change in elementary-internal and elementary (CORE-1693).

Link to Devin session: https://app.devin.ai/sessions/7ba4ec14b09c424c831f9d867f231fda
Open in Devin Desktop: https://app.devin.ai/desktop/session/7ba4ec14b09c424c831f9d867f231fda?variant=devin
Requested by: @haritamar


🟢 Devin Review found nothing to fix · View findings

Devin Review

Summary by CodeRabbit

  • Chores
    • Automated dependency reviews on pull requests and manual runs are no longer available.
    • License allowlist checks and the high-severity failure threshold are no longer applied.

…Snyk)

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@linear

linear Bot commented Nov 13, 2026

Copy link
Copy Markdown

CORE-1693

@github-actions

Copy link
Copy Markdown
Contributor

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@jonlevine7

jonlevine7 commented Nov 13, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request deletes the dependency-review GitHub Actions workflow and its configuration. The deleted configuration included an allowed-license list and a high-severity failure threshold.

Changes: Dependency review

Layer / File(s) Summary
Remove dependency review
.github/workflows/dependency-review.yml, .github/dependency-review-config.yml
The workflow that ran dependency-review-action@v4 and the configuration it used are deleted.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: Minimal · up to 3ae32

This removes the GitHub dependency-review check and its license and severity settings as part of the move to Snyk. It has no effect on runtime behavior. Before merging, confirm that Snyk covers the equivalent checks and that no branch-protection rule still requires the removed check.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: removal of the Dependency Review workflow. It also gives the reason, the switch from GHAS to Snyk. The raw summary shows the workflow file and its config file were del…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: removal of the Dependency Review workflow. It also gives the reason, the switch from GHAS to Snyk. The raw summary shows the workflow file and its config file were deleted, which matches the title. The title is specific and clear enough for a teammate scanning history.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f56ac2c4-6c6a-4e04-b5ff-aa266e8b8612
Commits

Reviewing files that changed from the base of the PR and between e3ab23d and 3ae3242.

Files selected for processing: 2

  • .github/dependency-review-config.yml
  • .github/workflows/dependency-review.yml
Files with no reviewable changes: 2

  • .github/dependency-review-config.yml
  • .github/workflows/dependency-review.yml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants