Skip to content

Tune ESLint object/type literal wrapping for multiline indentation #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Tune ESLint object/type literal wrapping for multiline indentation #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
230f170
Initial plan
Copilot Jul 21, 2026
eb06b75
chore: enforce multiline object indentation in eslint
Copilot Jul 21, 2026
45d5c82
Merge branch 'main' into copilot/fix-object-indentations
gohabereg Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/collaboration-manager/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/core/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {

@Reversean Reversean Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to '@stylistic/object-curly-newline': ['error', { multiline: true, consistent: true }] when considering all other issues.

ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',

@Reversean Reversean Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting 'never' breaks lint and deforms multiline imports into malformed syntax during autofix.

Perhaps it should be { multiline: true, consistent: true } (or omitted) to allow multiline imports?

ExportDeclaration: {
multiline: true,
minProperties: 3,

@Reversean Reversean Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like example copy-paste. And it's breaking existing code.

Should we really break 3+ items even when it fits inline?

consistent: true,
},
TSTypeLiteral: {

@Reversean Reversean Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it matters, parameter TSInterfaceBody is missing, so TypeScript types are not fully covered.

multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/dom-adapters/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/model-types/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/model/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/ot-server/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/playground/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/sdk/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/tools/bold/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/tools/inline-link/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/tools/italic/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/tools/paragraph/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
20 changes: 20 additions & 0 deletions packages/ui/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,26 @@ export default [
},
},
rules: {
'@stylistic/object-curly-newline': ['error', {
ObjectExpression: {
multiline: true,
consistent: true,
},
ObjectPattern: {
multiline: true,
consistent: true,
},
ImportDeclaration: 'never',
ExportDeclaration: {
multiline: true,
minProperties: 3,
consistent: true,
},
TSTypeLiteral: {
multiline: true,
consistent: true,
},
}],
'n/no-unpublished-import': ['error', {
allowModules: [
'eslint-config-codex',
Expand Down
Loading