Run ecs-go with the inherited terminal, so --turbo output is colored - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor/bin/ecs --turboprinted diffs without colors. ecs-go already colors its output, but only when stdout is a terminal - andpassthru()pipes the child's stdout through PHP, so ecs-go saw a pipe and turned colors off (the progress bar on stderr was not piped, so that one worked).Now ecs-go runs via
proc_open()with ECS's own STDIN/STDOUT/STDERR, so it gets the real terminal: colored diff, correct width. Piped or CI output stays plain, same as before.The command stays a string, as the array form of
proc_open()needs PHP 7.4 and the release is downgraded to 7.2.