Enable symplify/phpstan-rules 14.17 rule sets and fix reported errors - #84
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
fix-phpstan-rules-14-17
branch
from
September 28, 2026 11:56
44c7cec to
2972a73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symplify/phpstan-rules 14.17.0 auto-loads all rule sets (naming, complexity, configurable, static, symfony, symfonyConfig, doctrine, phpunit). This keeps them all enabled and fixes the new errors:
SniffFileProcessor::fixFile()- use$this->fixerinstead of passing the service as an argumentECSConfig- set sniff properties viaReflectionPropertyinstead of a dynamic property nameTurboRunner-FileSystem::delete()instead of@unlink()FileCacheStorage- drop@onvar_export(), errors are still caught viaerror_get_last()ParametersMerger- truthy check instead ofempty()tests/functions.phpdd()helperIgnored in
phpstan.neonby path:File::__construct()skips the parent constructor on purpose - it requires a PHP_CodeSnifferRulesetECS does not usestatic::classinAbstractSymplifyFixer::getName()property_exists()inTurboConfigDumperStandaloneLineConstructorParamFixerinLineLengthFixer- hack to avoid running both rules together