fix the multi-column load #376 - #413
Merged
Merged
Conversation
rozyczko
added
[scope] bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #413 +/- ##
===========================================
+ Coverage 94.54% 94.57% +0.03%
===========================================
Files 54 54
Lines 5517 5515 -2
===========================================
Hits 5216 5216
+ Misses 301 299 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Review follow-ups on the _load_txt/merge_datagroups fix: - The resolution variances are ~1e-9, so asserting them with assert_almost_equal passed even against zeros. Use assert_allclose with a relative tolerance in the three txt loading tests. - Cover a single-row file (the ndmin=2 path, which raised before this branch) and a comma-delimited file with extra columns. - Merge two different datasets of different lengths under a shared key, and assert dims, unit, length, order and variances. Merging a file with itself could not detect a reversed concatenation or lost uncertainties. - Say "additional numeric columns" (numpy still parses the whole file, so a trailing text column remains an error) and "the ORSO default" (the spec also permits FWHM, which the ORSO loader converts). State the sigma requirement on the public load() too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data loading improvements:
_load_txtto always read the first four columns as Qz, R, sR, sQz (in ORSO order), ignoring any extra columns, and clarified in the docstring that error columns are treated as standard deviations and squared to obtain variances.Data merging improvements:
merge_datagroupsto usesc.concatalong the correct dimension when merging shared keys, ensuring proper concatenation instead of overwriting.