Skip to content

Added exception when file exists and overwrite=false - #411

Merged
rozyczko merged 1 commit into
developfrom
374-json-exceptions
Sep 14, 2026
Merged

Added exception when file exists and overwrite=false#411
rozyczko merged 1 commit into
developfrom
374-json-exceptions

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Stricter error handling in material management:

  • The add_material method in Project now raises a ValueError if the material is already present in the collection, instead of printing a warning.
  • The remove_material method in Project raises a ValueError if the material is used by any model and an IndexError if the index is out of range, instead of printing errors.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix Fix to known bug [priority] high Should be prioritized soon labels Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.54%. Comparing base (dd3cb93) to head (084d9d6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #411      +/-   ##
===========================================
+ Coverage    94.52%   94.54%   +0.01%     
===========================================
  Files           54       54              
  Lines         5516     5517       +1     
===========================================
+ Hits          5214     5216       +2     
+ Misses         302      301       -1     
Flag Coverage Δ
integration 38.31% <14.28%> (-0.01%) ⬇️
unittests 94.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/project.py 94.36% <100.00%> (+0.10%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko
rozyczko merged commit 53be08b into develop Sep 14, 2026
58 of 60 checks passed
@rozyczko
rozyczko deleted the 374-json-exceptions branch September 14, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix to known bug [priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant