Correct weighted R-factor calculations and document reliability metrics - #224
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #224 +/- ##
===========================================
- Coverage 90.40% 90.39% -0.01%
===========================================
Files 284 284
Lines 24792 24789 -3
Branches 2910 2909 -1
===========================================
- Hits 22412 22409 -3
Misses 1754 1754
Partials 626 626
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use inverse-variance weights for wR calculations and document all reported reliability-factor equations. Add regression coverage for importing the ICSD ZrW₂O₈ CIF, including ionic atom symbols and cryspy conversion, and simplify the LaM₇O₃ tutorial sidebar label.