Skip to content

[8.0.0 Cherry-pick] Await enclave attestation in asynchronous command execution - #5066

Merged
cheenamalhotra merged 1 commit into
release/8.0from
dev/automation/pr-4887-to-8.0.0
Nov 13, 2026
Merged

cheenamalhotra merged 1 commit into
release/8.0from
dev/automation/pr-4887-to-8.0.0

Conversation

@github-actions

Copy link
Copy Markdown

Cherry-pick of #4887 (5f74e8f) into release/8.0.

* Await enclave attestation during asynchronous command execution

Integrate asynchronous enclave session preparation, creation, and invalidation with command cancellation and retry cleanup. Preserve synchronous behavior and shared metadata parsing; add deterministic and SQL-backed regression coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

* Retain describe connection ownership through reader registration

Give asynchronous describe processing sole ownership of its captured connection reservation. Preserve original write faults and cancellation after connection closure, retain describe mode through reconnect, and test delayed reader registration and setup failures.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

* Keep non-enclave command preparation inline and isolate test options

Preserve null-task completion for parameterless Always Encrypted commands without an enclave workflow. Isolate simulated enclave fixtures by application name so cached attestation options cannot leak across reused server endpoints. Add deterministic regressions for both paths.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

* Keep completed enclave batch preparation inline

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

* Revalidate connection after asynchronous enclave preparation

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

* Release retained connection reservation when enclave retry aborts

Fix Parser namespace imports after the stack rebase and cover provider faults and cancellation after successful session invalidation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

* Test inline asynchronous enclave retry cleanup

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

* Stabilize async command reservation fixture under coverage

Gate the simulated response until overlap assertions finish and return metadata-free DONE for the fixture's negotiated encryption capabilities.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 47a925b3-e0e6-43ed-9fb7-519060a206c2
@github-actions github-actions Bot added this to the 8.0.0 milestone Nov 13, 2026
@github-actions
github-actions Bot requested a review from a team as a code owner November 13, 2026 14:43
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Nov 13, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@cheenamalhotra

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.98693% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.50%. Comparing base (463a45c) to head (8b65db6).

Files with missing lines Patch % Lines
.../Microsoft/Data/SqlClient/SqlCommand.Encryption.cs 84.61% 24 Missing ⚠️
.../src/Microsoft/Data/SqlClient/SqlCommand.Reader.cs 68.18% 21 Missing ⚠️
...lClient/src/Microsoft/Data/SqlClient/SqlCommand.cs 95.74% 2 Missing ⚠️
...rc/Microsoft/Data/SqlClient/SqlCommand.NonQuery.cs 95.00% 1 Missing ⚠️
...ent/src/Microsoft/Data/SqlClient/SqlCommand.Xml.cs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/8.0    #5066      +/-   ##
===============================================
+ Coverage        68.97%   72.50%   +3.52%     
===============================================
  Files              314      314              
  Lines            45857    71133   +25276     
===============================================
+ Hits             31629    51573   +19944     
- Misses           14228    19560    +5332     
Flag Coverage Δ
CI-SqlClient ?
sqlclient-pr 72.50% <83.98%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra
cheenamalhotra merged commit a4458c7 into release/8.0 Nov 13, 2026
205 of 207 checks passed
@cheenamalhotra
cheenamalhotra deleted the dev/automation/pr-4887-to-8.0.0 branch November 13, 2026 22:27
@github-project-automation github-project-automation Bot moved this from To triage to Done in SqlClient Board Nov 13, 2026
@mdaigle mdaigle mentioned this pull request Nov 16, 2026
3 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant