Skip to content

vendor: github.com/docker/go-events v0.1.0 - #7256

Merged
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_go_events
Aug 28, 2026
Merged

vendor: github.com/docker/go-events v0.1.0#7256
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_go_events

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Review incomplete

chunk 1: Drafter did not complete (schema validation error in the drafter sub-agent — the structured output schema was rejected by the model API with HTTP 400 on all three delegation attempts)

Findings so far: ⚠️ INCOMPLETE


Note for maintainers: The automated drafter sub-agent could not be invoked due to a schema validation error (output_config.format.schema: Unsupported regex feature in pattern field). The orchestrator read the diff directly and found no bugs in the introduced code — but this is not a substitute for a completed automated review.

Manual inspection of the key changes:

  • broadcast.go: Refactored run() loop to use slices.Delete and an index-based loop (correctly avoids skipping sinks after deletion); logrus field ordering cleaned up.
  • channel.go: Write() now prioritizes the closed-channel check via an outer non-blocking select before the inner blocking select — a correctness improvement reducing the chance of racing against Close().
  • retry.go: math/randmath/rand/v2 (rand.N); uint64 + manual atomic ops → atomic.Uint64; minor refactoring of backoff(). All changes appear safe.
  • filter.go: Filter struct made unexported (filter), exported as a type alias Filter = filter — backward-compatible.
  • Vendoring metadata (vendor.mod, vendor.sum, vendor/modules.txt): version bumped consistently to v0.1.0; go 1.24 directive added to modules.txt; stale vendor.mod/vendor.sum files from the vendored dependency removed.

@vvoland
vvoland merged commit cef1e66 into docker:master Aug 28, 2026
104 checks passed
@thaJeztah
thaJeztah deleted the bump_go_events branch August 28, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants