vendor: github.com/docker/go-events v0.1.0 - #7256
Merged
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
⚠️ Review incomplete
chunk 1: Drafter did not complete (schema validation error in the drafter sub-agent — the structured output schema was rejected by the model API with HTTP 400 on all three delegation attempts)
Findings so far:
Note for maintainers: The automated drafter sub-agent could not be invoked due to a schema validation error (
output_config.format.schema: Unsupported regex feature in pattern field). The orchestrator read the diff directly and found no bugs in the introduced code — but this is not a substitute for a completed automated review.Manual inspection of the key changes:
broadcast.go: Refactoredrun()loop to useslices.Deleteand an index-based loop (correctly avoids skipping sinks after deletion); logrus field ordering cleaned up.channel.go:Write()now prioritizes the closed-channel check via an outer non-blocking select before the inner blocking select — a correctness improvement reducing the chance of racing againstClose().retry.go:math/rand→math/rand/v2(rand.N);uint64+ manual atomic ops →atomic.Uint64; minor refactoring ofbackoff(). All changes appear safe.filter.go:Filterstruct made unexported (filter), exported as a type aliasFilter = filter— backward-compatible.- Vendoring metadata (
vendor.mod,vendor.sum,vendor/modules.txt): version bumped consistently tov0.1.0;go 1.24directive added tomodules.txt; stalevendor.mod/vendor.sumfiles from the vendored dependency removed.
vvoland
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)