refactor: Rename icp to icp-project - #772
Open
adamspofford-dfinity wants to merge 2 commits into
Open
Conversation
Now that the app half has left, the crate holds only what a project is and what can be done to one, so `icp` is no longer the name for it — and `icp` was already the name of the binary, which made `icp::render::plain` in a tracing target mean the CLI rather than the library. Mechanical: the directory, the package name, the dependency entries and every `icp::` path become `icp-project` / `icp_project::`. Tracing targets named in test assertions are left alone, since those still name the binary. The checked-in guidance is brought up to date with the two crates: the workspace listing, the paths in `architecture.md`, the mock-helper note in `testing.md` (which now explains the `test-util` feature), and a new section describing the app/project boundary — which side a thing belongs on, the four seams that cross it, and why their errors are the one sanctioned exception to the per-action error-variant rule.
The convention the seam errors actually follow is `#[snafu(transparent)]`,
not a `{source}` display: restating the cause as the wrapper's own message
while still reporting it as a source prints it twice in every chain.
Says so, and says plainly that this is where `transparent` is allowed over a
boxed foreign error, since the rule below otherwise reserves it for this
repo's own error types.
adamspofford-dfinity
added this pull request to stack #777
September 11, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬