chore(ci): bump the dev-env image to v2.2.1 and drop the mops prewarm - #1483
Merged
Merged
Conversation
lwshang
approved these changes
Sep 15, 2026
v2.2.1 ships mops 3.2.2, which fixes the toolchain download race (caffeinelabs/mops#818) that the prewarm step worked around, so the step goes with it. Verified locally: `icp build` on motoko/pub-sub with a cold moc cache and no prewarm is 3/3 clean on 3.2.2, against 3/3 failures on the 3.1.0 that v2.0.0 shipped. 3.2.2 also closes GHSA-7w5x-hrqm-74c2 (CVSS 8.2), where a malformed mops.toml reached during dependency resolution hangs the parser. The image also moves icp-cli 1.3.0 -> 1.5.0, Node 24.15 -> 24.21, pnpm 11.4 -> 11.26 and yq 4.53.3 -> 4.53.6. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
marc0olo
force-pushed
the
chore/dev-env-v2.2.1
branch
from
September 15, 2026 15:53
d373a00 to
89a96dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
fix/flaky-example-testsmasterMerge bottom-up. GitHub has no stacked-PR view, so this table is maintained by hand.
Bumps the dev-env image
v2.0.0→v2.2.1and removes themops installprewarm step #1482 added, in one commit, because the two are coupled: dropping the prewarm before CI runs mops ≥ 3.2.1 brings the flake straight back.Why the prewarm can go
mops 3.2.1 fixed caffeinelabs/mops#818 — a version is now extracted into a staging directory and renamed into place under a per-version lock, and the project-local
.mops/_tmpscratch directory is gone. Verified against the real example rather than the changelog:icp buildonmotoko/pub-sub, cold moc cache, no prewarmmops build, cold cacheThe waiting process now prints
Waiting for another mops process to install moc <version>...and uses the finished install. 3.2.1 also replaced the opaqueexit code: undefinedwith the actual signal or spawn error.What else rides along
v2.2.1is not only mops:It also carries a security fix: mops 3.2.2 closes GHSA-7w5x-hrqm-74c2 / CVE-2026-85730 (CVSS 8.2, CWE-835), where
smol-tomlnever returns on a value followed by an unterminated comment inside an array or inline table. mops reads each installed dependency's ownmops.tomlduring resolution, so the exposure is through third-party manifests, not just your own file.Neither icp-cli 1.4.0 nor 1.5.0 has a breaking change, but 1.5.0 changes one behaviour worth watching here:
Eleven of 72 example
icp.yamlfiles declareenvironments:, so that is the most likely place for this bump to bite. Keeping the bump separate from #1482 is what makes a red check here attributable to the toolchain rather than to the flakiness fixes.🤖 Generated with Claude Code