Conversation
astro was pinned at ^7.1.6 (resolved 7.1.6), vulnerable to two published advisories fixed in later 7.x releases: - GHSA-26w7-cxv4-gfx2: remote code execution through AVIF image optimization (fixed in 7.2.8) - GHSA-376h-93r7-7g6f: authorization bypass from a missing path-segment boundary check when stripping the configured base (fixed in 7.2.4) This site builds with Astro's default static output (no adapter/SSR configured in astro.config.mjs), so the on-demand image and routing code paths these advisories describe are not exposed to site visitors. The exposure is limited to build-time processing of repository content (e.g. a malicious image landing in a content PR) -- still worth fixing since a patched release exists. - Bump astro ^7.1.6 -> ^7.3.2, and its peer @astrojs/markdown-remark ^7.2.2 -> ^7.3.1 to keep the peer dependency graph resolvable (astro 7.3.x requires @astrojs/markdown-remark ^7.3.0). - Pin the transitive astro -> vite -> postcss -> nanoid chain to nanoid ^3.3.19 via `overrides`: nanoid@3.3.17 has a separate advisory (custom generators loop indefinitely when called with size 0). Verified locally: - `npm audit`: 0 vulnerabilities (was 1 critical + 1 high) - `npm ci` installs cleanly from the regenerated lockfile - `npm run build` still produces the same 210 pages as before the bump Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
Closing as a duplicate of #384 (Dependabot), which already covers the astro 7.1.6→7.3.2 bump and beat me to it by 2 days — sorry for the noise, should have checked for an open Dependabot PR before opening this. One gap for whoever picks up #384: its lockfile diff doesn't touch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
astrowas pinned at7.1.6, which is affected by two published GitHubSecurity Advisories fixed in later 7.x releases:
Found via
npm auditafter a routine OSV/dependency sweep; not somethingI saw exploited, just a known-vulnerable version still in the lockfile.
Root cause / exposure
This site builds with Astro's default static output — no
output/adapteris configured in
astro.config.mjs— so the on-demand image and routingcode paths these advisories describe aren't exposed to visitors of
docs.internetcomputer.org. The realistic exposure is build-time
processing of repository content (e.g. a crafted image landing in a content
PR triggering the AVIF codepath during
astro build). Still worth fixingsince a patched release is available and it's a routine bump.
Fix
astro^7.1.6→^7.3.2, and its peer@astrojs/markdown-remark^7.2.2→^7.3.1(astro 7.3.x requires@astrojs/markdown-remark ^7.3.0as a peer, so both need bumping together or
npm installfails toresolve).
npm auditalso flaggednanoid@3.3.17(pulled intransitively via
astro → vite → postcss → nanoid) for a separateadvisory — custom generators loop indefinitely when called with size 0.
Pinned to
^3.3.19viaoverridessince it's several levels deep inAstro's own dependency tree and not something bumping astro alone fixes.
Verified locally
npm audit→ 0 vulnerabilities (was 1 critical + 1 high)npm ciinstalls cleanly from the regenerated lockfilenpm run buildstill produces the same 210 pages as before the bumpOnly
package.jsonandpackage-lock.jsonchanged — no content or config touched.🤖 Generated with Claude Code