Simplify GYB device definitions with feature defaults - #508
Merged
Merged
Conversation
Generated by 🚫 Danger |
Zandor300
force-pushed
the
t3code/support-gyb-named-parameters
branch
from
September 9, 2026 21:09
e00bde8 to
f17cd4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device definitions currently repeat long sequences of positional feature values. Add keyword-only feature parameters with defaults (
Falsefor flags and0for Apple Pencil support and cameras), and specify only supported features in each definition. Core specifications remain required.Updates all 134 device definitions and removes 1,543 redundant default values. Regenerated
Source/Device.generated.swift; its contents are byte-for-byte unchanged, so only the GYB template is included in the diff.Validation:
swift test: all 4 tests passed.git diff --check: passed.swiftlint --quiet: fails on the existing cyclomatic complexity violation atSource/Device.generated.swift:626(140 versus limit 10); also reports existing warnings, including obsolete rule names. The generated file and lint configuration are unchanged.