Repository navigation
fix: play a list of tracks the Web API names spotify:webapi with an id - #449
Merged
Merged
Conversation
The Web API now follows spotify:webapi with an id of its own, as in spotify:webapi:2rTTCnsdFHFb5KvCEsY2lb. That uri names no context either: the items still come inline. It was taken for a context uri of an unknown type, so a play naming "uris" failed with "unsupported context type", and nothing played. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Web API now follows
spotify:webapiwith an id of its own when it plays a request naminguris, as inspotify:webapi:2rTTCnsdFHFb5KvCEsY2lb. That uri names no context either: the tracks still come inline. Since #445 only the barespotify:webapiwas recognized, so the new form was taken for a context uri of an unknown type. The play then failed withunsupported context type, nothing played, and a later pause was refused with 403 "Restriction violated".IsWebApiTrackListUrinow acceptsspotify:webapiwith or without an id. Both places that looked for the bare uri use it: inferring a context's item type, and skipping the metadata sweep.Tests: the three existing Web API tests now also cover the uri with an id. They fail without the fix, and
go test -tags "test_unit test_integration" ./...passes with it.🤖 Generated with Claude Code