Skip to content

fix: valida la durata delle sessioni attività #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sajotrei wants to merge 2 commits into
base: master
Choose a base branch
from
+63 −1
Open

fix: valida la durata delle sessioni attività #1919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9d0a1
fix: valida durata sessioni attività
sajotrei Sep 26, 2026
10cdceb
test: copre validazione durata sessioni
sajotrei Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/interventi/src/Components/Sessione.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,13 @@ public function setTecnico($id_tecnico)
public function getOreCalcolateAttribute()
{
$inizio = new \DateTime($this->orario_inizio);
$diff = $inizio->diff(new \DateTime($this->orario_fine));
$fine = new \DateTime($this->orario_fine);

if ($fine <= $inizio) {
throw new \InvalidArgumentException('La data/ora di fine deve essere successiva alla data/ora di inizio.');
}

$diff = $inizio->diff($fine);
$ore = $diff->i / 60 + $diff->h + ($diff->days * 24);

return $ore;
Expand Down
57 changes: 57 additions & 0 deletions modules/interventi/tests/SessioneDurataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<?php

namespace Modules\Interventi\Tests;

use Modules\Interventi\Components\Sessione;
use PHPUnit\Framework\TestCase;

class SessioneDurataTest extends TestCase
{
public function testDurataValida(): void
{
$sessione = new Sessione();
$sessione->orario_inizio = '2026-09-02 14:30:00';
$sessione->orario_fine = '2026-09-02 18:30:00';

$this->assertSame(4.0, $sessione->ore_calcolate);
}

public function testDurataZeroNonValida(): void
{
$sessione = new Sessione();
$sessione->orario_inizio = '2026-09-02 14:30:00';
$sessione->orario_fine = '2026-09-02 14:30:00';

$this->expectException(\InvalidArgumentException::class);
$sessione->ore_calcolate;
}

public function testFinePrecedenteNonValida(): void
{
$sessione = new Sessione();
$sessione->orario_inizio = '2026-09-02 14:30:00';
$sessione->orario_fine = '2026-09-02 13:30:00';

$this->expectException(\InvalidArgumentException::class);
$sessione->ore_calcolate;
}

public function testCasoIssue1910NonValido(): void
{
$sessione = new Sessione();
$sessione->orario_inizio = '2026-09-02 14:30:00';
$sessione->orario_fine = '2026-08-27 18:30:00';

$this->expectException(\InvalidArgumentException::class);
$sessione->ore_calcolate;
}

public function testDurataSuPiuGiorniValida(): void
{
$sessione = new Sessione();
$sessione->orario_inizio = '2026-09-02 14:30:00';
$sessione->orario_fine = '2026-09-03 10:30:00';

$this->assertSame(20.0, $sessione->ore_calcolate);
}
}
Loading