Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough
ChangesGoogle Chrome repository setup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The test image replaces deprecated apt-key setup with a repository-scoped keyring, addressing Chrome installation on newer Debian-based Ruby images without an established merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The build process has been broken since the release of the 0.32
I believe it's like this because of the release of
trixie, since theapt-keyhas been deprecated for long and now it's not available intrixie.If you see the os of the
0.31.6it'sbookworm.docker run --rm -it decidim/decidim:0.31.6and then:
If you donwload the latest ruby image, it's based on
trixieThis PR fixes this issue by changing the installation of the
google-chrome-stablebinary, in theDockerfile-testenvironment. Since that build fails, the action does not continue with the production one.