Skip to content

Fix build process - #133

Open
davidbeig wants to merge 1 commit into
decidim:masterfrom
openpoke:fix/build-test
Open

davidbeig wants to merge 1 commit into
decidim:masterfrom
openpoke:fix/build-test

Conversation

@davidbeig

Copy link
Copy Markdown
Contributor

The build process has been broken since the release of the 0.32

I believe it's like this because of the release of trixie, since the apt-key has been deprecated for long and now it's not available in trixie.

If you see the os of the 0.31.6 it's bookworm.

docker run --rm -it decidim/decidim:0.31.6
and then:

root@f5845dbfb7fa:/code# cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

If you donwload the latest ruby image, it's based on trixie

$ docker run --rm -it ruby:3.4.7 bash
root@2436a532b2f9:/# cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 13 (trixie)"
NAME="Debian GNU/Linux"
VERSION_ID="13"
VERSION="13 (trixie)"
VERSION_CODENAME=trixie
DEBIAN_VERSION_FULL=13.2
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

This PR fixes this issue by changing the installation of the google-chrome-stable binary, in the Dockerfile-test environment. Since that build fails, the action does not continue with the production one.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 80765394-1adf-4ea4-a9de-c416f49ba94c

📥 Commits

Reviewing files that changed from the base of the PR and between 8d30d96 and 43552d4.

📒 Files selected for processing (1)
  • Dockerfile-test

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the test environment’s Google Chrome installation process to use a more secure, modern package repository configuration.
    • Preserved existing Chrome installation and cleanup behavior.

Walkthrough

Dockerfile-test now configures the Google Chrome repository with a dearmored signing key and signed-by, then installs Chrome and cleans apt caches.

Changes

Google Chrome repository setup

Layer / File(s) Summary
Keyring-based Chrome installation
Dockerfile-test
The Dockerfile downloads and dearmors the Google signing key, writes a signed repository entry, installs google-chrome-stable, and cleans apt caches.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 43552

The test image replaces deprecated apt-key setup with a repository-scoped keyring, addressing Chrome installation on newer Debian-based Ruby images without an established merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the main change as a build-process fix. It is broad but remains relevant to the Dockerfile installation update.
Description check ✅ Passed The description clearly explains the Debian trixie and apt-key issue and the Dockerfile-test change that fixes the build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant