pg_attribute: report timestamptz and array columns by their type, not as text - #423
Merged
sunng87 merged 1 commit intoSep 17, 2026
Conversation
…s arrow_pg::datatypes::into_pg_type can return, and everything else falls through to _ => TEXT. So a tz-aware timestamp column gets pg_attribute.atttypid 25, while SELECT on the same column describes it as 1184, and \d shows text. Clients that read column types from the catalog then see a different type from the one they get back when they query the column. The same thing happens to the int4[]/text[] columns in the catalog's own tables. The values for each new line are copied from PostgreSQL's pg_type rows.
sunng87
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PgAttributeTable::datafusion_to_pg_type handles only some of the types arrow_pg::datatypes::into_pg_type can return,
and everything else falls through to _ => TEXT. So a tz-aware timestamp column gets pg_attribute.atttypid 25, while
SELECT on the same column describes it as 1184, and \d shows text.
Clients that read column types from the catalog then see a different type from the one they get back when they
query the column. The same thing happens to the int4[]/text[] columns in the catalog's own tables. The values for
each new line are copied from PostgreSQL's pg_type rows.