Repository navigation
air get: overlap the text view's run-only lookups with get-output - #7626
Open
stevenchen-db wants to merge 2 commits into
Open
stevenchen-db wants to merge 2 commits into
stevenchen-db wants to merge 2 commits into
Conversation
`air get` in text mode made five requests one after another: runs/get, get-output, a second runs/get for the serverless environment version, the MLflow run name, and the training-config export. The environment lookup and the config export depend only on the run, so start them right after the first runs/get and let them overlap get-output; start the MLflow name lookup before waiting on them. The list picker's detail pane shares the renderer and gets the same overlap. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: dcad2e5
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air getin text mode made five requests one after another:runs/get,get-output, a secondruns/getfor the serverless environment version (the typed SDKRunhas noenvironments), the MLflow run name, and the training-config export. The environment lookup and the config export depend only on the run, so they now start right after the firstruns/getand overlapget-output; the MLflow name lookup starts before waiting on them. The list picker's detail pane uses the same renderer and gets the same overlap. JSON output is unchanged (it makes none of these lookups).Why
On df1,
air get <run>(text) went from ~536-581ms to ~380-404ms median (10 runs per build, interleaved).Tests
TestGetTextOverlapsRunOnlyLookupsWithGetOutput: the server answersget-outputonly after the config export and the secondruns/getarrive; it fails on main.go test ./cmd/air(touched tests also with-race),TestAccept/air, lint pass.air gettext and JSON output byte-identical on three runs; JSON makes the same two requests; theair listdetail pane renders the same with the same requests.This pull request and its description were written by Isaac.