Repository navigation
air: Include run details in air get JSON - #7624
Draft
artemy-kolesnikov wants to merge 6 commits into
Draft
artemy-kolesnikov wants to merge 6 commits into
artemy-kolesnikov wants to merge 6 commits into
Conversation
Expose typed accelerator, environment, retry, user, MLflow and sweep details without changing existing JSON fields. Read and emit the stored config only when --include-config is passed, because it may contain plaintext environment variables and parameters. Without it, config-derived retry limits remain unknown. Bound config downloads before SDK response buffering and omit oversized files in text and JSON. Guarantee an empty array for sweep tasks when iteration lookup fails. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 4 changed tests (limit=20, 0 not selected) 4 tests: regression=4 unreleased=0 coverage=0 failing=0
TestAccept/air/get: branch ✅ | main (c4559ed) ❌ | latest (v1.26.0) ❌main (c4559ed): latest (v1.26.0): TestAccept/air/get-ai-runtime: branch ✅ | main (c4559ed) ❌ | latest (v1.26.0) ❌main (c4559ed): latest (v1.26.0): TestAccept/air/get-pending: branch ✅ | main (c4559ed) ❌ | latest (v1.26.0) ❌main (c4559ed): latest (v1.26.0): TestAccept/air/help: branch ✅ | main (c4559ed) ❌ | latest (v1.26.0) ❌main (c4559ed): latest (v1.26.0): |
Collaborator
✅ Integration test reportCommit: cb575dd
Top 4 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
…etails Co-authored-by: Isaac <no-reply@databricks.com>
…etails Co-authored-by: Isaac <no-reply@databricks.com>
…etails Co-authored-by: Isaac <no-reply@databricks.com>
The config downloaded for the JSON output is reported verbatim, so a config uploaded from a Windows checkout (CRLF) produced different JSON than the same config uploaded from Unix (LF). Normalize the line endings for the machine-readable field; the text display already reformats the config. Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add typed run details to
air get -o json, including flat accelerator fields, environment, user, MLflow run name, retry-limit provenance and sweep details.--include-configopts into the stored config and its source. Downloaded configs larger than 1 MiB are omitted.Why
The text view exposes run details that machine-readable output omits, forcing consumers to parse the text display. Config is opt-in because it can contain plaintext environment variables and parameters. Without the flag, JSON does not read the config, so a retry limit that is not reported by the run is
nulleven when text can derive it from the stored config. This change depends on the retry-limit patch in #7623.Tests
tasksas an empty array.This pull request and its description were written by Isaac.