Repository navigation
Add genie_agents bundle resource #7617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eric-cho1
wants to merge
2
commits into
main
Choose a base branch
from
eric.cho/add-genie-agent-resource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * Add the `genie_agents` resource for managing AI/BI Genie agents on the direct deployment engine. |
14 changes: 14 additions & 0 deletions
14
acceptance/bundle/deployment/bind/genie_agent/databricks.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| bundle: | ||
| name: test-bundle | ||
|
|
||
| resources: | ||
| genie_agents: | ||
| agent1: | ||
| genie_agent_id: "01f0a1b2c3d4e5f60718293a4b5c6d7e" | ||
| display_name: bound-agent | ||
| warehouse_id: test-warehouse-id | ||
| definition: | ||
| config: | ||
| sample_questions: | ||
| - id: "01f0a1b2c3d4e5f60718293a4b5c6d7f" | ||
| question: What were total sales last month? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Cloud = false | ||
| EnvMatrix.DMS = ["", "true"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
|
|
||
| >>> [CLI] genie-agents create-genie-agent --json { | ||
| "display_name": "bound-agent", | ||
| "warehouse_id": "test-warehouse-id", | ||
| "definition": { | ||
| "config": { | ||
| "sample_questions": [ | ||
| {"id": "01f0a1b2c3d4e5f60718293a4b5c6d7f", "question": "What were total sales last month?"} | ||
| ] | ||
| } | ||
| } | ||
| } --genie-agent-id 01f0a1b2c3d4e5f60718293a4b5c6d7e | ||
| { | ||
| "name": "agents/01f0a1b2c3d4e5f60718293a4b5c6d7e", | ||
| "display_name": "bound-agent", | ||
| "warehouse_id": "test-warehouse-id", | ||
| "etag": "1" | ||
| } | ||
|
|
||
| >>> [CLI] bundle deployment bind agent1 01f0a1b2c3d4e5f60718293a4b5c6d7e --auto-approve | ||
| Successfully bound genie_agent with an id '01f0a1b2c3d4e5f60718293a4b5c6d7e' | ||
| Run 'bundle deploy' to deploy changes to your workspace | ||
|
|
||
| >>> [CLI] bundle summary | ||
| Name: test-bundle | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
| Resources: | ||
| Genie Agents: | ||
| agent1: | ||
| Name: bound-agent | ||
| URL: [DATABRICKS_URL]/genie/rooms/01f0a1b2c3d4e5f60718293a4b5c6d7e?w=[WORKSPACE_ID] | ||
|
|
||
| >>> [CLI] bundle deployment unbind agent1 | ||
|
|
||
| >>> [CLI] bundle summary | ||
| Name: test-bundle | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
| Resources: | ||
| Genie Agents: | ||
| agent1: | ||
| Name: bound-agent | ||
| URL: (not deployed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| AGENT="01f0a1b2c3d4e5f60718293a4b5c6d7e" | ||
|
|
||
| # Create the object outside the bundle with the CLI's own create command. | ||
| trace $CLI genie-agents create-genie-agent --json '{ | ||
| "display_name": "bound-agent", | ||
| "warehouse_id": "test-warehouse-id", | ||
| "definition": { | ||
| "config": { | ||
| "sample_questions": [ | ||
| {"id": "01f0a1b2c3d4e5f60718293a4b5c6d7f", "question": "What were total sales last month?"} | ||
| ] | ||
| } | ||
| } | ||
| }' --genie-agent-id "$AGENT" | agent_fields | ||
|
|
||
| trace $CLI bundle deployment bind agent1 "$AGENT" --auto-approve | ||
| trace $CLI bundle summary | ||
|
|
||
| trace $CLI bundle deployment unbind agent1 | ||
| trace $CLI bundle summary | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Project a genie agent read to the fields the test asserts. | ||
| agent_fields() { | ||
| jq '{name, display_name, warehouse_id, etag}' | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Genie agents are managed by the direct deployment engine. | ||
| Cloud = false | ||
|
|
||
| Ignore = [ | ||
| ".databricks", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| bundle: | ||
| name: test-bundle-$UNIQUE_NAME | ||
|
|
||
| resources: | ||
| genie_agents: | ||
| foo: | ||
| warehouse_id: $TEST_DEFAULT_WAREHOUSE_ID | ||
| display_name: test-genie-agent-$UNIQUE_NAME | ||
| description: This is a test genie agent # CAN_REMOVE | ||
| definition: | ||
| config: | ||
| sample_questions: | ||
| - id: "01f0a1b2c3d4e5f60718293a4b5c6d7e" | ||
| question: What were total sales last month? | ||
| data_sources: | ||
| tables: | ||
| - identifier: main.sales.orders | ||
| permissions: | ||
| - level: CAN_READ | ||
| group_name: users |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| resources.genie_agents.*.definition *genieagents.GenieAgentDefinition ALL | ||
| resources.genie_agents.*.definition.benchmarks *genieagents.GenieAgentBenchmarks ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions []genieagents.GenieAgentBenchmarkQuestion ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*] genieagents.GenieAgentBenchmarkQuestion ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*].answer []genieagents.GenieAgentBenchmarkAnswer ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*].answer[*] genieagents.GenieAgentBenchmarkAnswer ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*].answer[*].content string ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*].answer[*].format genieagents.GenieAgentBenchmarkAnswerFormat ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*].evaluation_note string ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*].id string ALL | ||
| resources.genie_agents.*.definition.benchmarks.questions[*].question string ALL | ||
| resources.genie_agents.*.definition.config *genieagents.GenieAgentConfig ALL | ||
| resources.genie_agents.*.definition.config.sample_questions []genieagents.GenieAgentSampleQuestion ALL | ||
| resources.genie_agents.*.definition.config.sample_questions[*] genieagents.GenieAgentSampleQuestion ALL | ||
| resources.genie_agents.*.definition.config.sample_questions[*].id string ALL | ||
| resources.genie_agents.*.definition.config.sample_questions[*].question string ALL | ||
| resources.genie_agents.*.definition.data_sources *genieagents.GenieAgentDataSources ALL | ||
| resources.genie_agents.*.definition.data_sources.mcp_connections []genieagents.GenieAgentMcpConnection ALL | ||
| resources.genie_agents.*.definition.data_sources.mcp_connections[*] genieagents.GenieAgentMcpConnection ALL | ||
| resources.genie_agents.*.definition.data_sources.mcp_connections[*].mcp_connection string ALL | ||
| resources.genie_agents.*.definition.data_sources.tables []genieagents.GenieAgentTable ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*] genieagents.GenieAgentTable ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs []genieagents.GenieAgentColumnConfig ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*] genieagents.GenieAgentColumnConfig ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].column string ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].description string ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].display_name string ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].enable_entity_matching bool ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].enable_format_assistance bool ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].exclude bool ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].synonyms []string ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].column_configs[*].synonyms[*] string ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].description string ALL | ||
| resources.genie_agents.*.definition.data_sources.tables[*].identifier string ALL | ||
| resources.genie_agents.*.definition.data_sources.volumes []genieagents.GenieAgentVolume ALL | ||
| resources.genie_agents.*.definition.data_sources.volumes[*] genieagents.GenieAgentVolume ALL | ||
| resources.genie_agents.*.definition.data_sources.volumes[*].description string ALL | ||
| resources.genie_agents.*.definition.data_sources.volumes[*].path string ALL | ||
| resources.genie_agents.*.definition.instructions *genieagents.GenieAgentInstructions ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls []genieagents.GenieAgentExampleQuestionSql ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*] genieagents.GenieAgentExampleQuestionSql ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].id string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters []genieagents.GenieAgentSqlParameter ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*] genieagents.GenieAgentSqlParameter ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].default_value *genieagents.GenieAgentSqlParameterDefaultValue ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].default_value.value_range *genieagents.GenieAgentSqlParameterDefaultRange ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].default_value.value_range.max string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].default_value.value_range.min string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].default_value.values []string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].default_value.values[*] string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].description string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].name string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].parameters[*].type_hint string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].question string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].sql string ALL | ||
| resources.genie_agents.*.definition.instructions.example_question_sqls[*].usage_guidance string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs []genieagents.GenieAgentJoinSpec ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*] genieagents.GenieAgentJoinSpec ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].comment string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].id string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].instruction string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].left genieagents.GenieAgentJoinSource ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].left.alias string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].left.identifier string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].relationship_type genieagents.GenieAgentJoinRelationshipType ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].right genieagents.GenieAgentJoinSource ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].right.alias string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].right.identifier string ALL | ||
| resources.genie_agents.*.definition.instructions.join_specs[*].sql string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_functions []genieagents.GenieAgentSqlFunction ALL | ||
| resources.genie_agents.*.definition.instructions.sql_functions[*] genieagents.GenieAgentSqlFunction ALL | ||
| resources.genie_agents.*.definition.instructions.sql_functions[*].id string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_functions[*].identifier string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets *genieagents.GenieAgentSqlSnippets ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions []genieagents.GenieAgentSqlExpression ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*] genieagents.GenieAgentSqlExpression ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*].alias string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*].display_name string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*].id string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*].instruction string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*].sql string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*].synonyms []string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.expressions[*].synonyms[*] string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters []genieagents.GenieAgentSqlFilter ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters[*] genieagents.GenieAgentSqlFilter ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters[*].display_name string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters[*].id string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters[*].instruction string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters[*].sql string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters[*].synonyms []string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.filters[*].synonyms[*] string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures []genieagents.GenieAgentSqlMeasure ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*] genieagents.GenieAgentSqlMeasure ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*].alias string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*].display_name string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*].id string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*].instruction string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*].sql string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*].synonyms []string ALL | ||
| resources.genie_agents.*.definition.instructions.sql_snippets.measures[*].synonyms[*] string ALL | ||
| resources.genie_agents.*.definition.instructions.text_instructions []genieagents.GenieAgentTextInstruction ALL | ||
| resources.genie_agents.*.definition.instructions.text_instructions[*] genieagents.GenieAgentTextInstruction ALL | ||
| resources.genie_agents.*.definition.instructions.text_instructions[*].content string ALL | ||
| resources.genie_agents.*.definition.instructions.text_instructions[*].id string ALL | ||
| resources.genie_agents.*.description string ALL | ||
| resources.genie_agents.*.display_name string ALL | ||
| resources.genie_agents.*.genie_agent_id string ALL | ||
| resources.genie_agents.*.id string INPUT | ||
| resources.genie_agents.*.lifecycle resources.Lifecycle INPUT | ||
| resources.genie_agents.*.lifecycle.depends_on []resources.DependsOn INPUT | ||
| resources.genie_agents.*.lifecycle.depends_on[*] resources.DependsOn INPUT | ||
| resources.genie_agents.*.lifecycle.depends_on[*].resource string INPUT | ||
| resources.genie_agents.*.lifecycle.prevent_destroy bool INPUT | ||
| resources.genie_agents.*.modified_status string INPUT | ||
| resources.genie_agents.*.parent_path string ALL | ||
| resources.genie_agents.*.url string INPUT | ||
| resources.genie_agents.*.warehouse_id string ALL | ||
| resources.genie_agents.*.permissions.object_id string ALL | ||
| resources.genie_agents.*.permissions[*] dresources.StatePermission ALL | ||
| resources.genie_agents.*.permissions[*].group_name string ALL | ||
| resources.genie_agents.*.permissions[*].level iam.PermissionLevel ALL | ||
| resources.genie_agents.*.permissions[*].service_principal_name string ALL | ||
| resources.genie_agents.*.permissions[*].user_name string ALL |
19 changes: 19 additions & 0 deletions
19
acceptance/bundle/resources/genie_agents/basic/databricks.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| bundle: | ||
| name: test-bundle | ||
|
|
||
| resources: | ||
| genie_agents: | ||
| agent1: | ||
| genie_agent_id: "01f0a1b2c3d4e5f60718293a4b5c6d7e" | ||
| display_name: my-agent | ||
| description: COMMENT1 | ||
| warehouse_id: test-warehouse-id | ||
| definition: | ||
| config: | ||
| sample_questions: | ||
| - id: "01f0a1b2c3d4e5f60718293a4b5c6d7f" | ||
| question: What were total sales last month? | ||
| data_sources: | ||
| tables: | ||
| - identifier: main.sales.orders | ||
| description: One row per order, with order date and amount. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Cloud = false | ||
| EnvMatrix.DMS = [""] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: Bind test never plans, deploys or destroys after binding
The script runs bind, summary, unbind, summary. It never checks that the first
bundle planafter bind is clean, thatbundle deploythen updates the bound agent in place rather than recreating it, or thatbundle destroyafterunbindleaves the agent alone. Thegenie_spacebind test checks all of these (bind, plan, deploy, get, unbind, destroy, get again).bundle/direct/dresources/README.mddescribes bind tests as verifying "that binding an existing resource and then deploying/destroying works correctly".This matters for agents in particular:
genie_agent_idis aprovided_id_fieldsentry (bundle/direct/dresources/configs/genie_agents.yml:5), so a local-vs-state difference on it plans a recreate (classifyIDField,bundle/direct/bundle_plan.go:718-722), and recreating an agent loses its conversation history. Bind also has resource-specific logic inbundle/direct/bind.go(it copies the etag for dashboards and genie_spaces and fills state from config). A regression in how bind seeds state for this resource would not be caught by the current test.Please extend the script to cover
bundle plan,bundle deploy,unbind,bundle destroy, and a finalget-genie-agent.Evidence:
acceptance/bundle/deployment/bind/genie_agent/script:16-20contains only bind, summary, unbind, summary.acceptance/bundle/deployment/bind/genie_space/scriptrunsbundle plan,bundle deploy,genie get-space,unbind,bundle destroy --auto-approveand a finalgenie get-space.Agreed by 2 reviewer model(s).