Repository navigation
air list: request larger AiTrainingService index pages - #7616
Merged
Merged
Conversation
`air list --all-status` pages the AiTrainingService index one request at a time. The server scans the whole workspace 50 workloads per page and keeps only the caller's runs, so a workspace with a few thousand workloads costs dozens of sequential round trips. Send page_size=1000 so servers that honor it scan more per page; servers that predate page_size ignore it. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
maggiewang-db
approved these changes
Nov 13, 2026
Collaborator
✅ Integration test reportCommit: 52d9c29
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air list --all-statusnow sendspage_size=1000when it pages the AiTrainingService index (/api/2.0/ai-training/workflows).Why
The index is served by AICM, which scans the whole workspace 50 workloads per page and returns only the caller's runs, so a workspace with a few thousand workloads costs dozens of sequential round trips (65 on e2-dogfood, 153 on df1). AICM ignores
page_sizetoday; the companion AICM change (https://github.com/databricks-eng/universe/pull/3086059) honors it, capped at 1,000. Servers that predate it ignore the parameter, so this is safe to ship first.With the AICM change on a LiteSwap unit in staging (e2-dogfood): 65 pages -> 4,
air list --all-status -o json3.8s -> 1.0s, identical output and the same 559 run IDs.Tests
TestListAiTrainingWorkflowsSendsPageSize: every page request carriespage_size=1000with the right page token.go test ./cmd/air,TestAccept/air, lint pass.page_size): text and JSON output identical to main, same page counts.This pull request and its description were written by Isaac.