Repository navigation
air list: drop the up-front /Me calls - #7615
Merged
Merged
Conversation
`air list` called /Me twice before listing: once for the current user name and once, via CurrentWorkspaceID, for the run links' ?o= hint. The detail pane made a third call for the same hint. Resolve the workspace ID with workspaceIDForRunLink, which reads the profile, environment, or host metadata and calls /Me only when none is set. Resolve the user name lazily: the AiTrainingService index is already scoped to the caller and never needs it, and the Jobs scan fetches it alongside the first runs/list page, waiting for it only when it first matches an AIR run's creator. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 93c4a9c
Top 3 slowest tests (at least 2 minutes):
|
ethanma-db
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air listcalled/Metwice before listing: once for the current user name and once, viaCurrentWorkspaceID, for the run links'?o=hint. The detail pane made another call for the same hint.workspaceIDForRunLink(as inair run): profile, environment, or host metadata, with/Meonly when none is set.--all-status) is already scoped to the caller and never needs it; the Jobs scan fetches it alongside the firstruns/listpage.Why
On df1 (median of 3): default
air list252ms -> 101ms,--all-users182ms -> 105ms,--all-statusdrops both/Mecalls (9518ms -> 9355ms).Tests
go test ./cmd/air,TestAccept/air, lint pass. (TestIndexStrategyOrdersAndLimitshas a pre-existing data race in its test server under-race, also on main.)--all-status,--all-users, user, accelerator and no-match filters); identical?o=links; the TUI detail pane renders the same with no/Mecall.This pull request and its description were written by Isaac.