Repository navigation
Fix TestPatchWheel flake: run the final pip install offline - #7610
Merged
Merged
Conversation
pip install checks for a newer pip against the configured index. When the package proxy answers that check with an unexpected Content-Type, pip prints a warning, and runCmd fails the test on any output. Pass --no-index (the wheel has no dependencies) and --disable-pip-version-check. Co-authored-by: Isaac <no-reply@databricks.com>
github-actions
Bot
added
the
test-only-fix
Collaborator
✅ Integration test reportCommit: c8733cf
Top 4 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 13, 2026 16:41
denik
enabled auto-merge
November 13, 2026 16:41
andrewnester
approved these changes
Nov 13, 2026
Collaborator
❌ Integration test reportCommit: d5978e9
60 interesting tests: 40 FAIL, 10 flaky, 7 RECOVERED, 3 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix the
TestPatchWheelflake on Windows. The finalpip installruns pip's self version check against the configured index. When the package proxy answers it with an unexpected Content-Type, pip prints a warning, andrunCmdfails the test on any output. Pass--no-index(the test wheel has no dependencies) and--disable-pip-version-check.Tests
Reproduced locally with
PIP_INDEX_URLpointing at a server that returns no Content-Type: before, the test fails with the same warning; after, it passes.go test ./libs/patchwheel/ -run TestPatchWheelpasses for python3.9-3.13.Dashboard
error/1413:
This pull request and its description were written by Isaac.