Repository navigation
acc: make retry warning order deterministic in sync upload-504 tests - #7604
Merged
Merged
Conversation
Sync progress is written to stdout from the event goroutine, while the retry warning is logged to stderr, so the two can interleave either way. Capture stderr separately and print it after the command finishes. Co-authored-by: Isaac <no-reply@databricks.com>
github-actions
Bot
added
DABs
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 3 tests: regression=0 unreleased=0 coverage=3 failing=0
|
Collaborator
✅ Integration test reportCommit: 9fcd3dd
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 13, 2026 18:15
denik
requested review from
andrewnester and
anton-107
and removed request for
anton-107
November 13, 2026 18:15
denik
enabled auto-merge
November 13, 2026 18:15
andrewnester
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TestAccept/cmd/sync/upload-504andTestAccept/bundle/sync/upload-504flake on all three OSes because the retry warning sometimes appears beforeAction: PUTinstead of after it:Sync progress events are written to stdout by the output goroutine (
libs/sync/output.go), while the retry warning is logged to stderr by the uploader, so their relative order is not defined.Changes
Both scripts redirect the sync command's stderr to a temp file (outside the synced directory, so it is not uploaded) and print it after the command. The output still records the retry warning and both import-file requests; only the warning's position is now fixed.
Tests
go test ./acceptance -run 'TestAccept/(cmd|bundle)/sync/upload-504' -count=20passes locally.Dashboard
Warn: retrying after 504 Gateway Timeout from POST /api/2.0/workspace-files/import-file/[PATH]printed beforeAction: PUT: hello.pyTests: TestAccept/cmd/sync/upload-504, TestAccept/bundle/sync/upload-504/DMS=
This pull request and its description were written by Isaac.