Repository navigation
direct: treat pipeline data_staging_options as a backend default - #7603
Draft
andrewnester wants to merge 2 commits into
Draft
andrewnester wants to merge 2 commits into
andrewnester wants to merge 2 commits into
Conversation
A Lakeflow Connect pipeline that omits ingestion_definition.data_staging_options was planned as "update" on every `bundle plan` and updated on every deploy. The backend fills the field with the destination catalog/schema and a volume named __databricks_ingestion_gateway_staging_data-<pipeline-id>. The direct engine saw a remote-only value with no matching rule and reported it as drift, although no config can ever match it because it embeds the pipeline's own id. Continuous pipelines were restarted by every deploy because of this. Add a `backend_defaults` rule without pinned values for ingestion_definition.data_staging_options in pipelines.yml. It only fires when the field is absent from both state and config, so an explicitly configured data_staging_options still participates in drift detection. Teach the fake server to fill in data_staging_options like the backend when ingestion_definition is set, the field is omitted, and a destination catalog exists, and add an acceptance test covering both the implicit (no-op plan) and explicit (remote change reported) cases. Fixes #7580 Co-authored-by: Isaac <no-reply@databricks.com>
andrewnester
requested review from
denik,
janniklasrose,
pietern and
shreyas-goenka
November 13, 2026 14:43
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/resources/pipelines/drift/data_staging_options/DMS=: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): TestAccept/bundle/resources/pipelines/drift/data_staging_options/DMS=true: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): |
Collaborator
✅ Integration test reportCommit: 9d31665
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #7580. With the direct engine, a Lakeflow Connect pipeline that omits
ingestion_definition.data_staging_optionsno longer shows a permanentupdateinbundle planor gets updated (and restarted) on every deploy.backend_defaultsrule foringestion_definition.data_staging_optionsinpipelines.yml.Why
The backend fills the field with the destination catalog/schema and a volume named after the pipeline id, so no config can ever match it. An explicitly configured
data_staging_optionsstill participates in drift detection because the rule only fires when the field is absent from both state and config.Tests
New acceptance test
acceptance/bundle/resources/pipelines/drift/data_staging_options(local only) covers the implicit no-op plan and a reported remote change on an explicit value.This PR was written by Claude Code.
This pull request and its description were written by Isaac.