Repository navigation
Retry the root path read in bundle destroy - #7597
Merged
Merged
Conversation
bundle destroy checks that the bundle root path exists with workspace/get-status before anything else. That read was not retried, so a single cut connection failed the whole destroy. It now retries transient failures like the other bundle get-status reads. azure: TestAccept/bundle/resources/volumes/set-storage-location Co-authored-by: Isaac <no-reply@databricks.com>
azure: TestAccept/bundle/resources/volumes/set-storage-location Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 4 tests: regression=1 unreleased=0 coverage=3 failing=0
TestAccept/bundle/destroy/get-status-500/DMS=: branch ✅ | main (66d86c1) ❌ | latest (v1.26.0) ❌main (66d86c1): latest (v1.26.0): same output as main (66d86c1) |
Collaborator
✅ Integration test reportCommit: 531edd0
Top 7 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 13, 2026 10:08
andrewnester
self-requested a review
November 13, 2026 10:52
andrewnester
left a comment
Contributor
There was a problem hiding this comment.
No blocking findings from a full pass; I'll take a manual look at the phases changes before approving.
andrewnester
approved these changes
Nov 13, 2026
Collaborator
❌ Integration test reportCommit: 5c0711e
50 interesting tests: 26 FAIL, 13 flaky, 8 RECOVERED, 3 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle destroynow retries theworkspace/get-statusread that checks whether the bundle root path exists, usingretry.IsTransientReadlike the other bundle get-status reads. A 404 is still not retried and still means "nothing to delete".New local acceptance test
bundle/destroy/get-status-500injects one 500 on that read and checks that destroy retries and succeeds. Without the fix it fails withError: Fault injected by test. (500 INJECTED).Why
Destroy calls
assertRootPathExistsbefore anything else, and that call had no retry, so one dropped connection failed the whole destroy. In cloud tests the test proxy reports the dropped connection as a 500 with the transport error as the body, which is theunexpected EOF (500 UNKNOWN)below.retry.IsTransientReadcovers both forms: the 500, and a bareunexpected EOFurl error when no proxy is in between.Not a regression: this call has had no retry since it was added. The same error showed up earlier on two deploy-time reads that are now retried: the state file read (moved to a retried
workspace/exportin #7129) and the sync root check (#7044). Those failures are all from before those PRs merged. The destroy root path check is the only call in the recent failures that still has no retry.Judgment call: I left the other unretried get-status calls alone, in
bundle/permissions(closestExistingObject,setPermissions). None of them shows up in these failures, so this PR stays small.Tests
acceptance/bundle/destroy/get-status-500(local, both DMS variants).go test ./acceptance -run 'TestAccept/bundle/(destroy|deploy)'and thebundle/phasesandlibs/retryunit tests pass.bundle/resources/volumes/set-storage-location, where the latest failure was.Dashboard:
Error: Get "[DATABRICKS_URL]/api/2.0/workspace/get-status?path=...%2F.bundle%2Ftestbundle-[UNIQUE_NAME]%2Fdefault": unexpected EOF (500 UNKNOWN)bundle destroy --auto-approveon Azurebundle destroyon GCPbundle destroyon AWSThis pull request and its description were written by Isaac.