Repository navigation
Wait past the SDK retry window when sync tests read remote state - #7592
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: a1dbd4a
Top 6 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 13, 2026 09:27
denik
enabled auto-merge
November 13, 2026 09:27
maksim-zuev-db
approved these changes
Nov 13, 2026
Collaborator
❌ Integration test reportCommit: b560b78
140 interesting tests: 79 MISS, 49 FAIL, 8 RECOVERED, 4 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TestSyncIncrementalFileSyncandTestSyncFullFileSyncflake on all three clouds. Sync uploads the file and prints its completion event, and then the check that reads it back times out:context canceledis only the test cleanup stoppingsync --watch. The real failure is the 30sEventuallyinremoteFileContent(and the same 30s inremoteDirContent,objectTypeandlanguage).Those reads go through the SDK, which retries throttled (429) requests for up to 5 minutes. The shared test workspace throttles these sync tests heavily; see #7558, which handles the same 429s on the upload side. The timing fits a read that is still retrying: in the failing runs the test fails about 30s after sync finished, then the in-flight read returns and the test exits. Failures include the very first read of a newly created empty file, where stale content can't explain a mismatch.
Changes
This complements #7558 (the completion-marker timeout), and the two don't touch the same lines.
Tests
go test ./integration/cmd/sync -run 'TestSyncFullFileSync|TestSyncIncrementalFileSync|TestSyncNestedFolderSync'passes against an AWS test workspace.Dashboard
Error: context canceledaftersync_test.go:161: Condition never satisfiedWritten by an AI agent (harness_auto).
This pull request and its description were written by Isaac.