Skip to content

[CNXT-2519] Clarify custom skill installation paths - #7572

Open
ben-hansen-db wants to merge 3 commits into
mainfrom
benhansen/cnxt-2519-install-path-help
Open

ben-hansen-db wants to merge 3 commits into
mainfrom
benhansen/cnxt-2519-install-path-help

Conversation

@ben-hansen-db

@ben-hansen-db ben-hansen-db commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Clarify the custom-directory install syntax, show valid databricks-ai-runtime examples without --experimental, and fix the deprecated install command suggestion.

Why

CNXT-2519: make the valid custom-directory command discoverable before users combine incompatible flags.

Tests

No tests added or run, as requested. Go build and formatting/diff checks passed.

This PR was written with Codex.

@ben-hansen-db
ben-hansen-db marked this pull request as ready for review November 12, 2026 20:02
@ben-hansen-db
ben-hansen-db requested review from a team and lennartkats-db as code owners November 12, 2026 20:02

@pardis-beikzadeh-db pardis-beikzadeh-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small inline comments.

Non-blocking, outside this diff: the deprecation message at legacy_skills.go:42 suggests databricks aitools install --skills <name>, which is rejected ("--skills requires --skills-only or --path"). Please change it to --skills-only --skills <name>, here or in a follow-up.

Comment thread cmd/aitools/install.go Outdated

Supported agents: ` + strings.Join(agents.SupportedNames(), ", "),
Example: ` # Install a selected skill for coding agents.
databricks aitools install --skills-only --skills databricks-ai-runtime --experimental

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

databricks-ai-runtime isn't experimental, so drop --experimental here and on line 115. The databricks air help installs it without the flag.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed --experimental from both databricks-ai-runtime examples in a453358.

Comment thread cmd/aitools/install.go Outdated
--skills-only Force raw skill files for every agent (no plugin; not with --path).
--skills name1,name2 Install only the named skills (with --skills-only/--path).
--path <dir> Write resolved skill files to a directory (no agents, no state).
Use instead of --skills-only when choosing an output directory.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this repeats the "(not with --path)" note on line 96. Please drop it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped the repeated explanation under --path in a453358. I also fixed the deprecated install message to suggest --skills-only --skills <name> as requested in your review. Build and rendered help checks passed; no tests added or run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants