Repository navigation
[CNXT-2599] Repeat job run link after streaming #7571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
22ae267
[CNXT-2599] Repeat run and logs links after streaming
ben-hansen-db d0d4ad7
Add release note
ben-hansen-db 88ac116
Limit final links to live log streams
ben-hansen-db b4d9a2d
Use workspace-host run links without an org hint
ben-hansen-db f4653ef
Remove minor AIR output change release note
ben-hansen-db c18586c
Merge remote-tracking branch 'origin/main' into benhansen/cnxt-2599-f…
ben-hansen-db 9e079b7
Repeat only the job run link after streaming
ben-hansen-db d1bc4f6
Cover final AIR run links and add release note
ben-hansen-db 3ff3882
Reuse submitted run URL in streaming footer
ben-hansen-db 77b19f7
Merge main and preserve workspace-aware run links
ben-hansen-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * Repeat the Jobs run link after live log streaming ends. ([#7571](https://github.com/databricks/cli/pull/7571)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add test coverage for the final links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestLogsCommandPrintsGuidanceWhenStreamingIsInterruptedalready sets up a live stream. Adding aruns/get-outputhandler would let it cover both the normal end and Ctrl-C.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added regression coverage in d1bc4f6: the fixture now transitions from RUNNING to a terminal state, and the command tests check the final Jobs link after both successful and failed streams, unchanged JSON output, and the link on interruption. Existing completed-run and past-retry checks still pass. Also restored
.nextchanges/air/final-log-links.mdas requested in your review. Focused command tests, Go vet, and changelog validation passed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pardis-beikzadeh-db Normal completion (success/failure, text/JSON) and Ctrl-C are covered in d1bc4f6 and 3ff3882. The final footer contains only the Jobs run URL, so it does not call
runs/get-output. The AIR changelog entry was also restored in d1bc4f6. Fullgo test ./cmd/air -count=1, Go vet, and changelog validation pass.