Repository navigation
Conversation
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
8cfc4f1 to
c3634a9
Compare
Adds a CLI-wide feedback command. Feedback is sent as a fast_feedback_log event to /telemetry-ext using only existing schema fields: --command goes in origin and selects the owning ES component for parent_ui, and the agent, run ID and CLI version go in the standard user agent. Feedback from a detected AI agent requires user confirmation. Co-authored-by: Isaac <no-reply@databricks.com>
c3634a9 to
2f69b13
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
@tedjt, this was just a quick agentic review. I'll look into how we can do this. Findings from
The affected unit tests and new feedback acceptance test passed. The cases above were verified locally using fake endpoints, terminal repros, and the repository's changelog validator. This comment was generated with GitHub MCP. |
Changes
Add
databricks feedback [--command "<command>"] MESSAGE, a single CLI-wide command for sending feedback to Databricks.--commandnames the command the feedback is about. Its top-level command group decides where the feedback is filed:--command "air ..."goes toModelTraining.AIRuntime.--command "bundle ..."goes toDeveloperEcosystem.CoreDabs.--command, goes toDeveloperEcosystem.DatabricksCLI.Adding a product means adding one entry to
productComponents.--commandmust name a real CLI command.Each submission is one
fast_feedback_logevent sent to/telemetry-extin the authenticated workspace. This is the event the in-product feedback widget records, and the change uses only the fields the schema has today:parent_ui--commandgroup (see above)originair_runorbundle_deploy;clifor general feedbackreference_event_idhttp_access_loguser_agentcmd/...,interactive/..., plusagent/<name>when an AI agent is detected andrun-id/<id>when--run-idis setui_versionscli:<version>can_be_contacted--can-be-contacted(default false)textConfirmation for AI agents. When an agent is detected (
useragent.AgentProvider), the command asks the user to confirm. When no terminal is attached, it refuses unless--yesis passed, and the error includes a note telling the agent to show the user the exact message first. Feedback from a human is sent without a prompt.Receipt. On success the command prints a reference ID, or
{"received": true, "feedback_id": ...}with-o json. It makes one upload attempt with a 30s timeout and no retries, because a retry after an ambiguous failure could file the same feedback twice.Supporting changes:
telemetry.Sendfor a single, synchronous upload.FrontendLogEntry.DatabricksCliLogis now taggedomitzero(it wasomitempty, which has no effect on struct values), so a feedback event carries onlyfast_feedback_log, matching the proto oneof.root.CommandStringsooriginuses the same command naming as telemetry.Why
Users, and agents acting for them, have no way to report CLI issues from the CLI itself. This builds on the goals of #7254 (AIR feedback with agent attribution, run context and a receipt), with three differences:
--commandroutes the feedback to the owning team.Tests
acceptance/cmd/feedbackcovers:--command(a product subcommand, a command group, a CLI-owned command) and no--command--yes(refused) and with--yes(agent/recorded)--commandand--run-idtelemetry.Send.This pull request and its description were written by Isaac.