Repository navigation
integration: share one workspace client across tests - #7555
Merged
Merged
Conversation
Same failure as #7507, on the Go integration test path: acc.WorkspaceTest built a client per test, so a timed-out OIDC discovery GET (not retried by the SDK) failed every test starting at that moment with "cannot configure default credentials". Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 4aadef1
Top 24 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 12, 2026 14:20
denik
requested review from
andrewnester,
rauchy and
rclarey
and removed request for
rauchy and
rclarey
November 12, 2026 14:20
andrewnester
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Go integration tests now share one SDK workspace client per test process.
acc.WorkspaceTestused to build a new one withdatabricks.NewWorkspaceClient()for every test.Why
This is the same flaky failure that #7507 fixed for acceptance tests, here on the Go integration test path. Each new client repeats OIDC endpoint discovery before its first API call, and the SDK does not retry that request when it times out. If the workspace is slow for a moment, every test starting then fails at its first API call with
default auth: cannot configure default credentials. The failures since #7507 merged all come fromintegration/internal/acc/fixtures.go.A shared client authenticates once and refreshes its token in the background. The SDK does not cache a failed authentication (
credentialsProvideris set only on success), so after a transient failure the next call on the shared client tries again. No integration test changes the client's config or theDATABRICKS_*auth env.Dashboard
error/1224
Tests
Ran locally against AWS:
integration/cmd/fs(25 tests: the 4 that failed plus others),integration/libs/filer(44) andintegration/cmd/workspace(14). All pass.This PR was created by an AI agent (harness_auto, opus5.5, isaac_claude).
This pull request and its description were written by Isaac.