Repository navigation
Add interactive pickers to aitools mcp add and remove - #7552
Draft
simonfaltum wants to merge 1 commit into
Draft
simonfaltum wants to merge 1 commit into
simonfaltum wants to merge 1 commit into
Conversation
Contributor
|
Commit: Regression test reportSelected 16 changed tests (limit=20, 0 not selected) 16 tests: regression=16 unreleased=0 coverage=0 failing=0
TestAccept/cmd/aitools/mcp/add-agent-not-installed: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): TestAccept/cmd/aitools/mcp/add-default-config: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): TestAccept/cmd/aitools/mcp/add-remove-agent-clis: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): TestAccept/cmd/aitools/mcp/add-text: branch ✅ | main (8e70c8b) ❌ | latest (v1.26.0) ❌main (8e70c8b): latest (v1.26.0): 12 more failure details omitted, see the full report in the run. |
simonfaltum
changed the base branch from
aitools-mcp/07-login
to
aitools-mcp/08-challenge
November 12, 2026 13:02
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 12, 2026 13:02
f9ffc67 to
2dd54b7
Compare
Collaborator
✅ Integration test reportCommit: 43a64fd
Top 9 slowest tests (at least 2 minutes):
|
simonfaltum
force-pushed
the
aitools-mcp/08-challenge
branch
from
November 12, 2026 14:42
38cdd13 to
1d8e6b3
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 12, 2026 14:44
2dd54b7 to
a1fd867
Compare
simonfaltum
force-pushed
the
aitools-mcp/08-challenge
branch
from
November 12, 2026 17:14
1d8e6b3 to
7b98424
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 12, 2026 17:15
a1fd867 to
b90afff
Compare
simonfaltum
force-pushed
the
aitools-mcp/08-challenge
branch
2 times, most recently
from
November 13, 2026 07:25
1c6aee6 to
7a9dca9
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
2 times, most recently
from
November 13, 2026 12:28
0aa2ee4 to
2dbdfe3
Compare
simonfaltum
changed the base branch from
aitools-mcp/08-challenge
to
aitools-mcp/08b-agent-clis
November 13, 2026 12:28
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 13, 2026 13:28
1fff1da to
e9bad5b
Compare
mcp add and mcp remove prompt for the profile, the services and the location when run in a terminal without flags. The agent picker and the proceed prompt are shared with install. The picker prompts use one help text, and a declined prompt ends with the same cancelled message. Main's install flow keeps its own scope title and plan output. The mcp add picker uses the global scope, which is the scope mcp add reports. Co-authored-by: Isaac <no-reply@databricks.com>
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 13, 2026 15:06
3ed1398 to
8cca61b
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 13, 2026 15:06
b30caa0 to
43a64fd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is part of the stack that adds the hidden
databricks aitools mcpcommand group. It sits on #7595, which adds and removes agent MCP entries through each agent's own CLI.databricks aitools mcp addandremovestopped in a terminal with "interactive selection is not available yet" when a flag was missing. This PR replaces that stopgap with pickers. Runs without a terminal keep their flags and output.Changes
addasks for the profile, the services and the agents that the flags do not give. The profile resolves as it does without a terminal, so the picker runs only where that stops with several profiles.(installed), unchecked. "Another schema..." lists another catalog and schema and keeps the checks.add,re-assert(only when the write leaves the entry as it is),updateorreplace. An agent whose config cannot be read is shown with the reason.addasksProceed?only when a picker made a choice. For each sign-in-required server it installed, it asks "Sign in now?" unless the caller is already signed in. Ctrl-C stops the remaining questions and prints the login command of each server still to sign in.removewith none of--names,--profileor--allshows the installed servers and asksProceed?before removing the picked ones.Why
Choosing servers needs their descriptions and sign-in requirements, which the workspace knows and the flags do not show.
Decisions to review
add --namesdoes.--namewithout--namesis refused rather than offered a single-select picker.add --helptext changed, so thehiddengolden changed. Theremoverefusal wording changed inrepair-and-warnings. No other non-interactive output changed.Tests
mcp_pickers_test.gocovers the service and profile pickers, the agent picker's failed check and the remove picker's refusal.mcp_add_test.goruns an interactiveaddthrough the prompt seams: refusals make no request, a changed host is refused after the pick, two schemas install, and a fully specified run asks only the sign-in question. It also covers the plan lines and a hung credential read.mcp_remove_test.goruns the remove picker end to end, including a declined confirmation.libs/aitools/mcp/binding_test.gocovers the profile check of a run without a service.go test -race ./cmd/aitools/ ./libs/aitools/... ./libs/cmdio/,./task test-exp-aitoolsandgo test ./acceptance -run TestAccept/cmd/aitoolspass.GOOS=windowsvet passes.This pull request and its description were written by Isaac.