Repository navigation
selection: list commit message names in the cmd, warn on rejected lines, exact CloudSlow bypass - #7548
Merged
Conversation
…es, exact CloudSlow bypass Follow-up to #7524 review comments. aws: TestAccept/cmd/fs/cp/file-to-file Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 85ddb53
Top 12 slowest tests (at least 2 minutes):
|
…ething Keeps selftest/selection_exclusions output unchanged for commits without names, and adds a case there that names tests. aws: TestAccept/selftest/selection_exclusions Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
denik
marked this pull request as ready for review
November 12, 2026 18:42
andrewnester
approved these changes
Nov 12, 2026
Collaborator
❌ Integration test reportCommit: 460df03
990 interesting tests: 862 MISS, 117 FAIL, 6 KNOWN, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #7524, addressing the review comments that came in after it merged:
CloudSlowbypass needs an exact name. Only a name that is the test dir itself, or one of its variants, liftsCloudSlow. A path above the dir (e.g.cloud: TestAccept/bundle) or a bareTestAcceptstill selects the whole subtree, but itsCloudSlowtests stay skipped under-short, which keeps the PR run insidecloud-select's 2h timeout. To support this,selection.Namednow records per dir whether a name was exact (Named.Exact).Test(aws: `TestAccept/x`, a trailing word, prose), now gets aWARNING: ignoring "<line>" ...in the test log, next to the existing warning for unmatched names.ParseCommitMessagereturns these lines, andFromCommitMessagenow returns aCommitSelectionwithSummary()andWarnings(), shared by the test runner and the cmd.go run ./acceptance/internal/selection/cmd [-cloud aws|azure|gcp]prints, after the changed tests, the tests the last commit message names for that run (empty-cloudmeans a local run) asgo test -runpatterns, plus the warnings. It does this only in git mode, and only when the message names something or has a warning, so the output for ordinary commits is unchanged. With paths as arguments it does not read the message.TestLastCommitMessageusesrunSelectionGit, which now returns git's output.commit_test.gomoves topackage selection_testto share it.acceptance/README.mdupdated.Why
Review comments from a code owner on #7524 that auto-merge landed before they were addressed.
Tests
aws:or unknown prefixes are not reported.Exactis set for a dir name and for a variant name, unset for a prefix name and for bareTestAccept, and an exact name wins over a prefix name for the same dir.Warnings()text.acceptance/selftest/selection_exclusionsgets a case that commits a message with names, covering the cmd's local and-cloud gcpoutput and both warnings.aws: TestAccept/cmd/fs/cp/file-to-file,cloud: TestAccept/bundle/validate/enum/DMS=true TestAccept/nopeandgcp: `TestAccept/cmd/fs/cp/dir-to-dir`:DATABRICKS_TEST_SELECT_CHANGED=50 go test ./acceptance -run '^TestAccept$' -vran the two named tests and logged both warnings.go run ./acceptance/internal/selection/cmdprinted^bundle$/^validate$/^enum$/^DMS=true$and^cmd$/^fs$/^cp$/^file-to-file$plus the warnings. With-cloud gcpit printed only thecloud:test.This pull request and its description were written by Isaac.