Repository navigation
acc: tolerate retried app deployment POST in apps lifecycle-started-omitted - #7547
Merged
Merged
Conversation
Follow-up to #7511: this test records the same start-then-deploy pair, so it is exposed to the same appdeploy.Deploy retry. Collapse consecutive duplicates with print_requests.py --unique. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
✅ Integration test reportCommit: b58c714
Top 23 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 12, 2026 16:32
denik
enabled auto-merge
November 12, 2026 16:32
andrewnester
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Collapse consecutive duplicate requests (
print_requests.py --unique) inapps/lifecycle-started-omitted, the same treatment #7511 gavelifecycle-startedandlifecycle-started-toggle.output.txtdoesn't change, because the trace line prints the wrapper function name.Why
Review feedback on #7511: this test also records a start followed by
POST /api/2.0/apps/{name}/deployments(the "started omitted -> started: true" step), so the sameappdeploy.Deployretry can record that POST twice. The dashboard shows no error/1031 failures for this test in the last 90 days, so this change prevents the flake rather than fixing an observed one. Consecutive duplicates are still collapsed only after GET filtering, as in #7511.Dashboard
Preventive; the same failure mode as error/1031, which has not been seen on this test yet.
Tests
go test ./acceptance -run 'TestAccept/bundle/resources/apps/lifecycle-started-omitted'passes.testme-aws -run 'TestAccept/bundle/resources/apps/lifecycle-started-omitted/'passes (DMS= and DMS=true).Opened by an AI agent (harness_auto, isaac_claude, opus5.5).
This pull request and its description were written by Isaac.