Skip to content

acc: drop no-op rm in apps/missing-service-principal - #7545

Merged
denik merged 1 commit into
mainfrom
denik/app-sp-hint-followup
Nov 12, 2026
Merged

denik merged 1 commit into
mainfrom
denik/app-sp-hint-followup

Conversation

@denik

@denik denik commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Changes

Follow-up to #7533, addressing review feedback: remove rm -f out.requests.txt from the bundle/resources/apps/missing-service-principal script. The harness records requests to $OUT_REQUESTS in a separate output dir, so the line did nothing. The golden output is unchanged: the first print_requests.py already listed the create request.

The hint text from #7533 stays as is ("wait for the deletion to finish"). Right after databricks apps delete, the app is still returned in DELETING, and bundle plan plans an update, not a create. IsGone is only checked for resources being deleted. So a redeploy run before the deletion finishes does not recreate the app. Details are in the review thread on #7533.

Tests

go test ./acceptance -run TestAccept/bundle/resources/apps/missing-service-principal passes locally with no output change.

Written by an AI agent (harness_auto, opus5.5, isaac_claude).

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto PRs made by AI loops & factories, label Nov 12, 2026
@denik
denik requested a review from andrewnester November 12, 2026 12:09
@github-actions github-actions Bot added DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code. labels Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Commit: 7c5b8a3be | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=0 unreleased=2 coverage=0 failing=0
test branch main (4668f26) latest (v1.26.0)
TestAccept/bundle/resources/apps/missing-service-principal/DMS= ✅ ✅ ❌
TestAccept/bundle/resources/apps/missing-service-principal/DMS=true ✅ ✅ ❌
TestAccept/bundle/resources/apps/missing-service-principal/DMS=: branch ✅ | main (4668f26) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1373: Diff:
        --- bundle/resources/apps/missing-service-principal/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsmissing-service-principalDMS=1611804660/002/output.txt
        @@ -11,10 +11,8 @@
         
         >>> errcode [CLI] bundle deploy
         Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app.
        +Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app. (400 BAD_REQUEST)
         
        -The app cannot be updated or started without its service principal. To recreate the app, delete it with "databricks apps delete myappname", wait for the deletion to finish, and run "databricks bundle deploy" again, using the same profile and target as for this deploy. Deleting the app also deletes its deployment history (400 BAD_REQUEST)
        -
         Endpoint: POST [DATABRICKS_URL]/api/2.0/apps/myappname/update
         HTTP Status: 400 Bad Request
         API error_code: BAD_REQUEST
        @@ -56,10 +53,8 @@
         
         >>> errcode [CLI] bundle deploy
         Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app.
        +Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app. (400 BAD_REQUEST)
         
        -The app cannot be updated or started without its service principal. To recreate the app, delete it with "databricks apps delete myappname", wait for the deletion to finish, and run "databricks bundle deploy" again, using the same profile and target as for this deploy. Deleting the app also deletes its deployment history (400 BAD_REQUEST)
        -
         Endpoint: POST [DATABRICKS_URL]/api/2.0/apps/myappname/start
         HTTP Status: 400 Bad Request
         API error_code: BAD_REQUEST
TestAccept/bundle/resources/apps/missing-service-principal/DMS=true: branch ✅ | main (4668f26) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1373: Diff:
        --- bundle/resources/apps/missing-service-principal/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsmissing-service-principalDMS=t518922478/002/output.txt
        @@ -11,10 +11,8 @@
         
         >>> errcode [CLI] bundle deploy
         Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app.
        +Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app. (400 BAD_REQUEST)
         
        -The app cannot be updated or started without its service principal. To recreate the app, delete it with "databricks apps delete myappname", wait for the deletion to finish, and run "databricks bundle deploy" again, using the same profile and target as for this deploy. Deleting the app also deletes its deployment history (400 BAD_REQUEST)
        -
         Endpoint: POST [DATABRICKS_URL]/api/2.0/apps/myappname/update
         HTTP Status: 400 Bad Request
         API error_code: BAD_REQUEST
        @@ -56,10 +53,8 @@
         
         >>> errcode [CLI] bundle deploy
         Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app.
        +Error: cannot update resources.apps.mykey: updating id=myappname: App: myappname's service principal does not exist or is deleted. App cannot run without a valid service principal. Please delete your app. (400 BAD_REQUEST)
         
        -The app cannot be updated or started without its service principal. To recreate the app, delete it with "databricks apps delete myappname", wait for the deletion to finish, and run "databricks bundle deploy" again, using the same profile and target as for this deploy. Deleting the app also deletes its deployment history (400 BAD_REQUEST)
        -
         Endpoint: POST [DATABRICKS_URL]/api/2.0/apps/myappname/start
         HTTP Status: 400 Bad Request
         API error_code: BAD_REQUEST
        
FAIL

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 7c5b8a3

Run: 43215378125

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 16 10:12
💚​ aws-windows-latest-4core-16gb 1 272 14 7:20
💚​ azure linux-2core-8gb 1 269 16 12:27
💚​ azure-windows-latest-4core-16gb 1 271 14 8:46
💚​ gcp linux-2core-8gb 1 270 16 10:42
💚​ gcp-windows-latest-4core-16gb 1 272 14 9:05
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 11 slowest tests (at least 2 minutes):
duration env testname
4:34 gcp-windows-latest-4core-16gb TestAccept
3:58 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
3:55 gcp linux-2core-8gb TestAccept
3:51 aws linux-2core-8gb TestAccept
3:42 azure linux-2core-8gb TestAccept
3:05 azure-windows-latest-4core-16gb TestAccept
2:56 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
2:54 aws-windows-latest-4core-16gb TestAccept
2:35 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:19 gcp-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files
2:07 azure linux-2core-8gb TestImportDirWithOverwriteFlag

@denik
denik marked this pull request as ready for review November 12, 2026 16:32
@denik
denik requested review from a team as code owners November 12, 2026 16:32
@denik
denik enabled auto-merge November 12, 2026 16:32
@denik
denik added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit de536db Nov 12, 2026
28 checks passed
@denik
denik deleted the denik/app-sp-hint-followup branch November 12, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories, DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants