Repository navigation
logstream test: unblock tail-flush handler via t.Context() - #7543
Merged
Merged
Conversation
t.Context() is canceled before t.Cleanup runs, so the handler can wait on it instead of a release channel closed by a defer. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: bddd3b3
Top 9 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 12, 2026 12:34
andrewnester
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #7505, addressing this review comment.
The
TestLogStreamerTailFlushesWithoutFollowserver handler now waits on<-t.Context().Done()instead of areleasechannel closed by adefer.t.Context()is canceled just beforet.Cleanupfunctions run, so the handler unblocks beforenewTestLogServer's cleanup waits for it. This matches thestopCtxhandlers elsewhere in the file and removes the channel along with the comment about defer ordering.Tests
go test -race -count=50 -run 'TestLogStreamerTailFlushesWithoutFollow$' ./libs/apps/logstream/passes, and so does the whole package.This pull request and its description were written by Isaac.