Repository navigation
acc: name OIDC discovery as the unretried auth request - #7542
Merged
Merged
Conversation
Follow-up to #7507 review: the SDK retries the M2M token exchange; only the OIDC endpoint discovery GET is not retried on timeout. Co-authored-by: Isaac <no-reply@databricks.com>
denik
marked this pull request as ready for review
November 12, 2026 12:29
Collaborator
✅ Integration test reportCommit: a488233
Top 11 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Nov 12, 2026
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 14, 2026
…abricks#7561) ## Changes Section 1 now says that when a PR description points at a review thread on another PR, read that thread after forming your own view and check the new text answers the ask made there. ## Why Follow-up PRs (databricks#7546, databricks#7541, databricks#7542) carry their intent in a parent PR's thread; the skill only covered the description and left the thread unread. ## Tests Skill text only. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Comment-only follow-up to #7507, addressing this review comment.
The comment on
cloudWorkspaceStatesaid auth resolution was not retried. That was inaccurate: the SDK wraps the M2M token exchange inNewRetryingTokenSource. Only the OIDC endpoint discovery GET (getOidcEndpointsviarefreshClient, which retries only throttling errors) is left unretried on timeout. The comment now names the discovery request.Tests
No behavior change;
go build ./acceptance/internal/passes.This PR was created by an AI agent (harness_auto, opus5.5, isaac_claude).
This pull request and its description were written by Isaac.