Skip to content

acc: name OIDC discovery as the unretried auth request - #7542

Merged
denik merged 1 commit into
mainfrom
acc-cloud-client-comment
Nov 12, 2026
Merged

denik merged 1 commit into
mainfrom
acc-cloud-client-comment

Conversation

@denik

@denik denik commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Changes

Comment-only follow-up to #7507, addressing this review comment.

The comment on cloudWorkspaceState said auth resolution was not retried. That was inaccurate: the SDK wraps the M2M token exchange in NewRetryingTokenSource. Only the OIDC endpoint discovery GET (getOidcEndpoints via refreshClient, which retries only throttling errors) is left unretried on timeout. The comment now names the discovery request.

Tests

No behavior change; go build ./acceptance/internal/ passes.

This PR was created by an AI agent (harness_auto, opus5.5, isaac_claude).

This pull request and its description were written by Isaac.

Follow-up to #7507 review: the SDK retries the M2M token exchange; only the
OIDC endpoint discovery GET is not retried on timeout.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto PRs made by AI loops & factories, label Nov 12, 2026
@denik
denik requested a review from andrewnester November 12, 2026 12:07
@github-actions github-actions Bot added the test-only-fix PRs that update failing of flaky tests without changing CLI code. label Nov 12, 2026
@denik denik changed the title acceptance: name OIDC discovery as the unretried auth request acc: name OIDC discovery as the unretried auth request Nov 12, 2026
@denik
denik marked this pull request as ready for review November 12, 2026 12:29
@denik
denik requested a review from a team as a code owner November 12, 2026 12:29
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: a488233

Run: 43215204694

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 11:28
💚​ aws-windows-latest-4core-16gb 1 272 13 6:52
💚​ azure linux-2core-8gb 1 269 15 11:57
💚​ azure-windows-latest-4core-16gb 1 271 13 10:11
💚​ gcp linux-2core-8gb 1 270 15 11:05
💚​ gcp-windows-latest-4core-16gb 1 272 13 6:37
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 11 slowest tests (at least 2 minutes):
duration env testname
4:17 azure-windows-latest-4core-16gb TestAccept
4:01 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
3:52 azure linux-2core-8gb TestAccept
3:51 aws linux-2core-8gb TestAccept
3:45 gcp linux-2core-8gb TestAccept
3:44 aws-windows-latest-4core-16gb TestAccept
2:57 gcp-windows-latest-4core-16gb TestAccept
2:34 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:07 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
2:03 azure-windows-latest-4core-16gb TestFilerWorkspaceNotebook/rJupyterNb.ipynb
2:00 azure-windows-latest-4core-16gb TestFilerReadDir/workspace_files_extensions

@denik
denik added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 71549d8 Nov 12, 2026
28 checks passed
@denik
denik deleted the acc-cloud-client-comment branch November 12, 2026 13:01
idelafuente-oc pushed a commit to idelafuente-oc/cli that referenced this pull request Nov 14, 2026
…abricks#7561)

## Changes
Section 1 now says that when a PR description points at a review thread
on another PR, read that thread after forming your own view and check
the new text answers the ask made there.

## Why
Follow-up PRs (databricks#7546, databricks#7541, databricks#7542) carry their intent in a parent PR's
thread; the skill only covered the description and left the thread
unread.

## Tests
Skill text only.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories, test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants