Repository navigation
retry: say why the inactivity timeout is matched by message - #7541
Merged
Merged
Conversation
Follow-up to #7521 review. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 8430283
Top 9 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 12, 2026 13:32
andrewnester
approved these changes
Nov 12, 2026
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 14, 2026
…abricks#7561) ## Changes Section 1 now says that when a PR description points at a review thread on another PR, read that thread after forming your own view and check the new text answers the ask made there. ## Why Follow-up PRs (databricks#7546, databricks#7541, databricks#7542) carry their intent in a parent PR's thread; the skill only covered the description and left the thread unread. ## Tests Skill text only. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Document in
libs/retry/retry.gowhyisInactivityTimeoutmatches the SDK's error message: the SDK builds "request timed out after ... of inactivity" withfmt.Errorfinhttpclient/api_client.goand exports no sentinel error or type for it.Why
Follow-up to #7521, addressing review feedback that merged before it was handled. An exported sentinel in the SDK would be the better long-term fix; until one exists, the message match follows the SDK's exact format string (prefix and suffix).
Tests
Comment-only change;
go test ./libs/retrypasses.This pull request and its description were written by Isaac.