Skip to content

retry: say why the inactivity timeout is matched by message - #7541

Merged
denik merged 1 commit into
mainfrom
followup-7521-inactivity-comment
Nov 12, 2026
Merged

denik merged 1 commit into
mainfrom
followup-7521-inactivity-comment

Conversation

@denik

@denik denik commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Changes

Document in libs/retry/retry.go why isInactivityTimeout matches the SDK's error message: the SDK builds "request timed out after ... of inactivity" with fmt.Errorf in httpclient/api_client.go and exports no sentinel error or type for it.

Why

Follow-up to #7521, addressing review feedback that merged before it was handled. An exported sentinel in the SDK would be the better long-term fix; until one exists, the message match follows the SDK's exact format string (prefix and suffix).

Tests

Comment-only change; go test ./libs/retry passes.

This pull request and its description were written by Isaac.

Follow-up to #7521 review.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto PRs made by AI loops & factories, label Nov 12, 2026
@denik
denik requested a review from andrewnester November 12, 2026 12:07
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 8430283

Run: 43215121368

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 9:49
💚​ aws-windows-latest-4core-16gb 1 272 13 7:26
💚​ azure linux-2core-8gb 1 269 15 10:17
💚​ azure-windows-latest-4core-16gb 1 271 13 8:39
💚​ gcp linux-2core-8gb 1 270 15 7:25
💚​ gcp-windows-latest-4core-16gb 1 272 13 7:30
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 9 slowest tests (at least 2 minutes):
duration env testname
3:41 azure-windows-latest-4core-16gb TestAccept
3:30 aws-windows-latest-4core-16gb TestAccept
3:26 gcp linux-2core-8gb TestAccept
3:21 azure linux-2core-8gb TestAccept
3:20 aws linux-2core-8gb TestAccept
3:11 gcp-windows-latest-4core-16gb TestAccept
2:27 azure-windows-latest-4core-16gb TestFilerReadDir/workspace_files
2:18 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:14 azure-windows-latest-4core-16gb TestFilerReadWrite/workspace_files_extensions

@denik
denik marked this pull request as ready for review November 12, 2026 13:32
@denik
denik requested a review from a team as a code owner November 12, 2026 13:32
@denik
denik added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 2848f68 Nov 12, 2026
43 of 45 checks passed
@denik
denik deleted the followup-7521-inactivity-comment branch November 12, 2026 14:13
idelafuente-oc pushed a commit to idelafuente-oc/cli that referenced this pull request Nov 14, 2026
…abricks#7561)

## Changes
Section 1 now says that when a PR description points at a review thread
on another PR, read that thread after forming your own view and check
the new text answers the ask made there.

## Why
Follow-up PRs (databricks#7546, databricks#7541, databricks#7542) carry their intent in a parent PR's
thread; the skill only covered the description and left the thread
unread.

## Tests
Skill text only.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants