Repository navigation
Assign setup-local files outside cmd/environments to eng-deco-ax - #7535
Merged
Merged
Conversation
Two setup-local files fell outside the local environments CODEOWNERS rules: the overrides.go hook that attaches setup-local to the environments command group, and the setup-local telemetry types. Co-authored-by: Isaac <no-reply@databricks.com>
rugpanov
marked this pull request as ready for review
November 12, 2026 10:03
rugpanov
requested review from
anton-107 and
shreyas-goenka
and removed request for
shreyas-goenka
November 12, 2026 10:03
rclarey
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add two CODEOWNERS rules for
@databricks/eng-deco-ax:/cmd/workspace/environments/overrides.go: attachessetup-localto theenvironmentscommand group./libs/telemetry/protos/setup_local.go: setup-local telemetry types.The rules come after
/libs/telemetry/because the last matching rule wins.Why
The rest of setup-local (
cmd/environments/,libs/localenv/,acceptance/localenv/,integration/cmd/environments/) is already owned byeng-deco-ax. These two files were owned only byeng-deco-cli(overrides.go) or byeng-deco-cliandeng-deco-platform(setup_local.go), so setup-local owners were not requested on changes to them.Tests
git diff --checkpasses.main.This pull request and its description were written by Isaac.