Skip to content

Assign setup-local files outside cmd/environments to eng-deco-ax - #7535

Merged
rugpanov merged 1 commit into
mainfrom
codeowners-setup-local
Nov 12, 2026
Merged

rugpanov merged 1 commit into
mainfrom
codeowners-setup-local

Conversation

@rugpanov

Copy link
Copy Markdown
Contributor

Changes

Add two CODEOWNERS rules for @databricks/eng-deco-ax:

  • /cmd/workspace/environments/overrides.go: attaches setup-local to the environments command group.
  • /libs/telemetry/protos/setup_local.go: setup-local telemetry types.

The rules come after /libs/telemetry/ because the last matching rule wins.

Why

The rest of setup-local (cmd/environments/, libs/localenv/, acceptance/localenv/, integration/cmd/environments/) is already owned by eng-deco-ax. These two files were owned only by eng-deco-cli (overrides.go) or by eng-deco-cli and eng-deco-platform (setup_local.go), so setup-local owners were not requested on changes to them.

Tests

  • git diff --check passes.
  • Both paths exist on main.

This pull request and its description were written by Isaac.

Two setup-local files fell outside the local environments CODEOWNERS
rules: the overrides.go hook that attaches setup-local to the
environments command group, and the setup-local telemetry types.

Co-authored-by: Isaac <no-reply@databricks.com>
@rugpanov
rugpanov marked this pull request as ready for review November 12, 2026 10:03
@rugpanov
rugpanov requested a review from a team as a code owner November 12, 2026 10:03
@rugpanov
rugpanov requested review from anton-107 and shreyas-goenka and removed request for shreyas-goenka November 12, 2026 10:03
@rugpanov
rugpanov added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 437e24a Nov 12, 2026
24 checks passed
@rugpanov
rugpanov deleted the codeowners-setup-local branch November 12, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants