Repository navigation
pr-review skill: read CI evidence before running tests - #7532
Open
andrewnester wants to merge 1 commit into
Open
andrewnester wants to merge 1 commit into
andrewnester wants to merge 1 commit into
Conversation
Say what to do when gh pr checks reports nothing, how to verify a harness or CI-selection change actually ran, and how to read the Integration test report (flaky vs RECOVERED, known_failures.txt). Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pass 9 now says what to do when
gh pr checksreports no checks, how to confirm a harness or CI-selection change actually ran (grep the job log), and how to read the Integration test report: flaky versus RECOVERED, andknown_failures.txtonciconfig.Why
Three reviews this morning (#7184, #7511, #7524) each needed one of these and the skill did not cover them.
Tests
Docs only.
This pull request and its description were written by Isaac.