Repository navigation
Update Go SDK to v0.198.0 - #7530
Merged
Merged
Conversation
Collaborator
✅ Integration test reportCommit: c1838a6
Top 6 slowest tests (at least 2 minutes):
|
This was referenced Nov 13, 2026
- acceptance/ssh/agent-launchers/output.txt - acceptance/cmd/workspace/apps/run-local-node/output.txt The bumper recorded 'Exit code' stubs instead of the real output for these tests. Restore the main versions; the SDK bump does not affect them.
Co-authored-by: Isaac <no-reply@databricks.com>
…on/go-sdk-v0.198.0 # Conflicts: # acceptance/bundle/resources/postgres_branches/recreate_source_branch_time/out.plan.json # acceptance/bundle/resources/postgres_branches/update_protected/out.plan.no_change.json # acceptance/bundle/resources/postgres_branches/update_protected/out.plan.restore.json # acceptance/bundle/resources/postgres_branches/update_protected/out.plan.update.json # acceptance/bundle/resources/postgres_databases/update/out.plan.no_change.json # acceptance/bundle/resources/postgres_databases/update/out.plan.restore.json # acceptance/bundle/resources/postgres_databases/update/out.plan.update.json # acceptance/bundle/resources/postgres_endpoints/remove_suspend_timeout/out.plan.drift.json # acceptance/bundle/resources/postgres_endpoints/remove_suspend_timeout/out.plan.json # acceptance/bundle/resources/postgres_endpoints/update_autoscaling/out.plan.no_change.json # acceptance/bundle/resources/postgres_endpoints/update_autoscaling/out.plan.restore.json # acceptance/bundle/resources/postgres_endpoints/update_autoscaling/out.plan.update.json # acceptance/bundle/resources/postgres_endpoints/update_pg_settings/out.plan.json # acceptance/bundle/resources/postgres_endpoints/update_suspend_timeout/out.plan.json # acceptance/bundle/resources/postgres_projects/add_default_endpoint_settings/out.plan.json # acceptance/bundle/resources/postgres_projects/remove_history_retention/out.plan.drift.json # acceptance/bundle/resources/postgres_projects/remove_history_retention/out.plan.json # acceptance/bundle/resources/postgres_projects/update_default_endpoint_suspend/out.plan.json # acceptance/bundle/resources/postgres_projects/update_display_name/out.plan.no_change.json # acceptance/bundle/resources/postgres_projects/update_display_name/out.plan.restore.json # acceptance/bundle/resources/postgres_projects/update_display_name/out.plan.update.json # acceptance/bundle/resources/postgres_projects/update_history_retention/out.plan.json # acceptance/bundle/resources/postgres_roles/update/out.plan.no_change.json
- Classify materialized_features[*].notifications as immutable; the new spec no longer marks it output-only. - Regenerate postgres and bundle/invariant goldens against #7596's testserver, dropping the drift the bumper recorded. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
approved these changes
Nov 13, 2026
Contributor
|
Note AI-generated comment (cli-tests-fix agent). The acceptance failures on this PR are not caused by the SDK change. They come from postgres golden files that were regenerated before #7596 merged:
To fix: rebase onto main, drop this PR's changes to postgres goldens (including |
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 14, 2026
## Changes Since 2026-11-12 the postgres API returns `spec` on GET for projects, branches, endpoints, databases and roles, where before it returned only `status`. The CLI already reads the embedded spec into the remote state, so plans now show remote values for spec fields. Fields that match the config no longer show up as `"action": "skip", "reason": "spec:input_only"` changes. This is a backend change: nothing postgres-related changed in the CLI on main in that window, and SDK v0.197.0→v0.198.0 has no change to `service/postgres/model.go`. - `libs/testserver`: postgres GET now echoes spec the way the cloud does: - on create, the spec as sent; - on update, merged by `update_mask`: a masked field missing from the body keeps its value, and setting one oneof member clears the others; - without the fields that stay input-only (project `pg_version`; branch `source_branch`, `source_branch_lsn`, `source_branch_time`; role `postgres_role`, `auth_method`, `identity_type`). - Goldens regenerated with `-update` against AWS. The two local-only tests (`postgres_branches/update_expire_time`, `recreate_source_branch_time`) were updated locally. - Stale "GET does not echo spec" comments in `bundle/direct/dresources` updated. This also unblocks the SDK bump PRs (databricks#7530, databricks#7584). Their regenerated configs drop `spec:input_only` for these fields. Against a testserver that still strips spec, that turns into phantom drift, which is the "Unexpected action='update'" in `invariant/no_drift`. With this PR's testserver plus databricks#7530's `*.generated.yml`, all `postgres_*`, `invariant` and `deploy/readplan` acceptance tests pass on this PR's goldens with no further changes. Decision: I updated the goldens rather than recording less, because the change is a permanent backend fix (spec echo), and the remote values make the plans more precise. Not in this PR: on main, the generated configs (`bundle/direct/dresources/configs/postgres_*.generated.yml`) still mark these fields `spec:input_only`, so the CLI keeps ignoring remote-only changes to them. Those files are generated from the OpenAPI annotations, and the SDK bump PRs regenerate them. This PR only makes the tests match the new API and keeps them passing both before and after that regeneration. ## Tests - `testme-aws -update` for `postgres_{projects,branches,endpoints,databases,roles}`: pass. - Full local acceptance suite and `libs/testserver` / `bundle/direct/...` unit tests: pass. New unit tests cover the spec merge rules. - The last commit names the postgres suites with `cloud:` so CI runs them on all clouds. ## Dashboard | error | snippet | |---|---| | [error/3387](http://go/cli/dashboard/error/3387?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `"new": "259200s", + "remote": "604800s"` (postgres_branches/update_ttl) | | [error/3389](http://go/cli/dashboard/error/3389?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `"new": "600s", "remote": "300s"` | | [error/3390](http://go/cli/dashboard/error/3390?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `Plan differs (out.plan.json): Unexpected output "display_name": ..., "history_retention_duration"` | | [error/3407](http://go/cli/dashboard/error/3407?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3408](http://go/cli/dashboard/error/3408?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `Unexpected output "attributes": { "createdb": ...` (postgres_roles/update) | | [error/3409](http://go/cli/dashboard/error/3409?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3414](http://go/cli/dashboard/error/3414?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `"old": "300s", "remote": "300s"` | | [error/3410](http://go/cli/dashboard/error/3410?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3411](http://go/cli/dashboard/error/3411?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `Unexpected output "default_endpoint_settings": { "autoscaling_limit_max_cu": 4,` | | [error/3412](http://go/cli/dashboard/error/3412?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `"new": "16000", "remote": "8000"` | | [error/3413](http://go/cli/dashboard/error/3413?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3424](http://go/cli/dashboard/error/3424?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3415](http://go/cli/dashboard/error/3415?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3419](http://go/cli/dashboard/error/3419?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `"new": 4, "remote": 8` (postgres_endpoints/update_autoscaling) | | [error/3416](http://go/cli/dashboard/error/3416?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3417](http://go/cli/dashboard/error/3417?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3425](http://go/cli/dashboard/error/3425?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `+ "postgres_database": "initial_db_name", + "role": ".../roles/app-owner"` | | [error/3418](http://go/cli/dashboard/error/3418?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) / [error/3420](http://go/cli/dashboard/error/3420?main=1&pr=1&end=2026-11-13T09:00:00Z&last=3d) | `Unexpected output "is_protected": false, "no_expiry": true,` | This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Go SDK dependency and generates APIs from that release's OpenAPI specification.