Repository navigation
air: Skip purged runs in air list --all-status - #7517
Closed
abdulkareem-db wants to merge 2 commits into
Closed
abdulkareem-db wants to merge 2 commits into
abdulkareem-db wants to merge 2 commits into
Conversation
runs/get reports a purged run as 400 INVALID_PARAMETER_VALUE "Run <id>
does not exist.", which the SDK maps to ErrResourceDoesNotExist.
hydrateJobRuns only dropped 403/404, so one purged run failed the whole
listing. Drop ErrResourceDoesNotExist too, and stop wrapping the error a
second time ("failed to get run X: failed to get run X: ...").
Fixes CNXT-2565.
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
Co-authored-by: Isaac <no-reply@databricks.com>
abdulkareem-db
force-pushed
the
air-list-skip-purged-runs
branch
from
November 11, 2026 22:23
eea15ed to
d939850
Compare
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
caroline-db
reviewed
Nov 11, 2026
Author
|
Superseded by #7523, reopened from a branch in this repository so CI can run (fork PRs can't get the OIDC token for the package proxy). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks air list --all-statusno longer fails when one of the listed runs has been purged.hydrateJobRunsnow drops runs whoseruns/getcall returnsapierr.ErrResourceDoesNotExist, alongside the existing 403/404 handling, and returns the per-run error without wrapping it a second time.Why
runs/getreports a purged run as400 INVALID_PARAMETER_VALUE"Run does not exist." rather than 404, sohydrateJobRunstreated it as a systemic error and the errgroup failed the whole listing:The Go SDK already maps that response (scoped to
GET /api/2.x/jobs/runs/get) toErrResourceDoesNotExist, so matching the sentinel avoids string-matching the message. Other errors (5xx, otherINVALID_PARAMETER_VALUEresponses, auth) still fail the batch. The doubled "failed to get run" prefix came from wrapping in bothfetchJobRunandhydrateJobRuns; the outer wrap is removed.Tracked internally as CNXT-2565.
Tests
cmd/air/joblist_test.goagainst anhttptestserver (so the SDK's error mapping is exercised): purged (400 "does not exist"), 403 and 404 runs are dropped and the rest keep their order; a 500 and an unrelated 400 still fail with a singlefailed to get run N:prefix. Both tests fail on the previous code.go test ./cmd/air/...andgo test ./acceptance -run TestAccept/air/listpass.This pull request and its description were written by Isaac.