Repository navigation
air: validate log node indices before fetching logs - #7516
Merged
Merged
Conversation
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/air/logs: branch ✅ | main (c7d55d3) ❌ | latest (v1.26.0) ❌main (c7d55d3): latest (v1.26.0): same output as main (c7d55d3) TestAccept/air/logs-mlflow-fallback: branch ✅ | main (c7d55d3) ❌ | latest (v1.26.0) ❌main (c7d55d3): latest (v1.26.0): same output as main (c7d55d3) |
Collaborator
✅ Integration test reportCommit: 5249b20
Top 33 slowest tests (at least 2 minutes):
|
pardis-beikzadeh-db
approved these changes
Nov 12, 2026
pardis-beikzadeh-db
left a comment
Contributor
There was a problem hiding this comment.
Approving, on the assumption Maggie's two comments get addressed before merge (+1 to both). A few nits below.
cmd/air/logdownload.go:69: nit: runLogs now holds run, so it could pass run (or numNodes) into downloadLogs. That drops this second runs/get and the check at line 81, which can no longer fail.
maggiewang-db
approved these changes
Nov 12, 2026
maggiewang-db
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for addressing the feedback.
caroline-db
force-pushed
the
air/validate-log-node-index
branch
from
November 12, 2026 23:25
9880c43 to
5249b20
Compare
caroline-db
enabled auto-merge
November 12, 2026 23:40
Collaborator
❌ Integration test reportCommit: 46b2b77
86 interesting tests: 74 FAIL, 8 RECOVERED, 4 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air logs --nodevalue when the run node count can be determinedWhy
An invalid node index could look like a successful run with no logs, even when another node had logs.
Tests
go test ./cmd/air./task lint-q./task checks