Repository navigation
Plan grants and permissions as updates without DoCreate - #7510
Draft
janniklasrose wants to merge 7 commits into
Draft
janniklasrose wants to merge 7 commits into
janniklasrose wants to merge 7 commits into
Conversation
janniklasrose
force-pushed
the
janniklasrose/optional-do-create
branch
from
November 11, 2026 21:23
064a1ed to
1d3cdec
Compare
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 122 not selected) 46 tests: regression=42 unreleased=0 coverage=4 failing=0
TestAccept/bundle/deploy/update-without-create/DMS=/READPLAN=: branch ✅ | main (1d69dfe) ❌ | latest (v1.26.0) ❌main (1d69dfe): latest (v1.26.0): same output as main (1d69dfe) TestAccept/bundle/deploy/update-without-create/DMS=/READPLAN=1: branch ✅ | main (1d69dfe) ❌ | latest (v1.26.0) ❌main (1d69dfe): latest (v1.26.0): same output as main (1d69dfe) TestAccept/bundle/deploy/update-without-create/DMS=true/READPLAN=: branch ✅ | main (1d69dfe) ❌ | latest (v1.26.0) ❌main (1d69dfe): latest (v1.26.0): same output as main (1d69dfe) TestAccept/bundle/deploy/update-without-create/DMS=true/READPLAN=1: branch ✅ | main (1d69dfe) ❌ | latest (v1.26.0) ❌main (1d69dfe): latest (v1.26.0): same output as main (1d69dfe) TestAccept/bundle/resources/catalogs/rename/DMS=/READPLAN=: branch ✅ | main (1d69dfe) ❌ | latest (v1.26.0) ❌main (1d69dfe): latest (v1.26.0): 37 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: 2ad675f
Top 27 slowest tests (at least 2 minutes):
|
janniklasrose
force-pushed
the
janniklasrose/optional-do-create
branch
from
November 11, 2026 22:22
1d3cdec to
2ad675f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Based on #7422. Make
DoCreateoptional and requireIDFromStateplusDoUpdatewhen it is absent. Grants and permissions, including secret-scope ACLs, now plan as updates on their first deployment. Existing assignments are read during planning when their ID is available; new parent IDs resolve during apply. Older saved plans that request creation of these resources fail before deployment with an instruction to regenerate the plan.Why
Grants and permissions update their parent’s access settings. They should not appear as newly created objects. The capability also replaces #7422’s temporary grants-only adoption setting.
Tests
This PR was written with Codex.