Skip to content

acc: clone a tiny repo in bundle/debug/fetch-repository-info - #7508

Merged
denik merged 1 commit into
mainfrom
fix-fetch-repository-info-timeout
Nov 12, 2026
Merged

denik merged 1 commit into
mainfrom
fix-fetch-repository-info-timeout

Conversation

@denik

@denik denik commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Changes

acceptance/bundle/debug/fetch-repository-info now creates its two Git folders from databricks/databricks-empty-ide-project (a 4 KB repo) instead of databricks/bundle-examples (about 4.4 MB). A new [BRANCH] replacement covers the default branch, which is main on the fake workspace and ide on the real repo.

Why

POST /api/2.0/repos clones the repo before it responds. With bundle-examples the clone sometimes took longer than the client's 90s inactivity timeout, mostly on GCP. The test creates two Git folders, so each run had two chances to hit it. It has been flaky like this since it was added in #6303.

The repo size matters. The integration test this acceptance test replaced cloned bundle-examples and hit the same timeout about 120 times. TestSyncEnsureRemotePathIsUsableIfRepoExists clones the empty IDE project in the same runs and hit it 9 times. On AWS, each variant of this test went from about 48s to about 19s.

Judgment calls:

  • No retry was added to the CLI. POST /repos is not idempotent: after a client-side timeout the server may still finish creating the repo, and a retry would then fail with "already exists".
  • The test still checks what it is for: the same git metadata is resolved under /Repos and outside it, and a path outside any Git folder resolves to nothing.

Tests

  • Local: passes.
  • Cloud, AWS (testme-aws): passes, about 19s per variant (was about 48s).
  • GCP and Azure were not run locally (no credentials here). In this PR's integration run the test passed on all six cloud/OS jobs, 18-37s per variant, GCP included.

Dashboard:

Opened by an AI agent (harness_auto, opus5.5, isaac_claude).

This pull request and its description were written by Isaac.

POST /api/2.0/repos clones synchronously; cloning bundle-examples
intermittently exceeded the 90s inactivity timeout, mostly on GCP.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto PRs made by AI loops & factories, label Nov 11, 2026
@github-actions github-actions Bot added DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code. labels Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Commit: 01099d975 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=0 unreleased=0 coverage=2 failing=0
test branch main (cec3f63) latest (v1.26.0)
TestAccept/bundle/debug/fetch-repository-info/DMS= ✅ ✅ ✅
TestAccept/bundle/debug/fetch-repository-info/DMS=true ✅ ✅ ✅

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 01099d9

Run: 43091970226

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 274 15 8:05
✅​ aws-windows-latest-4core-16gb 276 13 5:40
✅​ azure linux-2core-8gb 273 15 8:00
✅​ azure-windows-latest-4core-16gb 275 13 4:56
✅​ gcp linux-2core-8gb 274 15 9:55
✅​ gcp-windows-latest-4core-16gb 276 13 5:33
Top 7 slowest tests (at least 2 minutes):
duration env testname
4:10 azure linux-2core-8gb TestAccept
4:09 gcp-windows-latest-4core-16gb TestAccept
4:03 gcp linux-2core-8gb TestAccept
3:54 aws linux-2core-8gb TestAccept
3:38 azure-windows-latest-4core-16gb TestAccept
3:02 aws-windows-latest-4core-16gb TestAccept
2:03 gcp linux-2core-8gb TestExportDir

@denik
denik marked this pull request as ready for review November 11, 2026 22:05
@denik
denik requested review from a team as code owners November 11, 2026 22:05
@denik
denik requested a review from anton-107 November 11, 2026 22:05
@denik
denik enabled auto-merge November 11, 2026 22:08
@andrewnester
andrewnester self-requested a review November 12, 2026 08:58
@denik
denik added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 1b677a3 Nov 12, 2026
28 checks passed
@denik
denik deleted the fix-fetch-repository-info-timeout branch November 12, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories, DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants