Repository navigation
acc: clone a tiny repo in bundle/debug/fetch-repository-info - #7508
Merged
Merged
Conversation
POST /api/2.0/repos clones synchronously; cloning bundle-examples intermittently exceeded the 90s inactivity timeout, mostly on GCP. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
✅ Integration test reportCommit: 01099d9
Top 7 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 11, 2026 22:05
denik
enabled auto-merge
November 11, 2026 22:08
andrewnester
self-requested a review
November 12, 2026 08:58
andrewnester
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
acceptance/bundle/debug/fetch-repository-infonow creates its two Git folders fromdatabricks/databricks-empty-ide-project(a 4 KB repo) instead ofdatabricks/bundle-examples(about 4.4 MB). A new[BRANCH]replacement covers the default branch, which ismainon the fake workspace andideon the real repo.Why
POST /api/2.0/reposclones the repo before it responds. With bundle-examples the clone sometimes took longer than the client's 90s inactivity timeout, mostly on GCP. The test creates two Git folders, so each run had two chances to hit it. It has been flaky like this since it was added in #6303.The repo size matters. The integration test this acceptance test replaced cloned bundle-examples and hit the same timeout about 120 times.
TestSyncEnsureRemotePathIsUsableIfRepoExistsclones the empty IDE project in the same runs and hit it 9 times. On AWS, each variant of this test went from about 48s to about 19s.Judgment calls:
POST /reposis not idempotent: after a client-side timeout the server may still finish creating the repo, and a retry would then fail with "already exists".Tests
testme-aws): passes, about 19s per variant (was about 48s).Dashboard:
Error: Post "[DATABRICKS_URL]/api/2.0/repos": request timed out after 1m30s of inactivityError: Post "[DATABRICKS_URL]/api/2.0/repos": unexpected EOFOpened by an AI agent (harness_auto, opus5.5, isaac_claude).
This pull request and its description were written by Isaac.