Repository navigation
Keep PostgreSQL plan snapshots stable when GET echoes spec - #7503
Open
janniklasrose wants to merge 3 commits into
Open
janniklasrose wants to merge 3 commits into
janniklasrose wants to merge 3 commits into
Conversation
janniklasrose
marked this pull request as ready for review
November 11, 2026 19:12
Contributor
|
Commit: Regression test reportSelected 3 changed tests (limit=20, 0 not selected) 6 tests: regression=0 unreleased=0 coverage=6 failing=0
|
…s-plan-snapshot-parity
Collaborator
✅ Integration test reportCommit: e147f9e
7 interesting tests: 7 flaky
Top 36 slowest tests (at least 2 minutes):
|
…s-plan-snapshot-parity
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Compare planned updates in three PostgreSQL acceptance tests, excluding skipped fields and remote metadata from their plan snapshots. Keep the existing error, request, and retained-value assertions.
Why
The live API echoes some
specfields on GET, while the test server omits them. This changesspec:input_onlyentries and remote values without changing the planned operations. All six test variants fail on clean main in Azure. These failures also block #7006 and #7496.Tests
Regenerated the snapshots locally; the changed tests also pass under Go 1.27.3. All six Azure variants pass with the updated snapshots; one was rerun after a workspace state-upload timeout. The unmodified main baseline failed all six variants.
Formatting, repository checks, and full lint pass. Before the latest merge from main, the full Linux/macOS/Windows CI matrix and all six cloud CI jobs passed across AWS, Azure, and GCP on Linux and Windows. CI is rerunning for the refreshed head; the fixture diff is unchanged.
This PR was written with Codex.