Skip to content

Lead regression report comments with a status heading - #7500

Draft
janniklasrose wants to merge 3 commits into
mainfrom
janniklasrose/regression-report-heading
Draft

janniklasrose wants to merge 3 commits into
mainfrom
janniklasrose/regression-report-heading

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Changes

Keep a single ## Regression test report heading first, followed by ✅ when branch tests pass/skip or ❌ when any reported branch test fails. Reference-only failures do not turn it red. Match the plain heading text instead of a hidden marker, and insert commit/workflow links below the complete heading.

Why

Slack truncates comment previews. Starting with the report name and branch status makes the notification actionable instead of showing a commit URL.

Tests

  • Regression report unit tests pass, including pass/skip, reference-only failures, partial branch failures, and failures on both branch and main.
  • Mocked both workflow scripts: heading/status preservation, metadata placement, legacy comment matching, status transitions, cleanup, truncation, and unrelated comments.
  • ./task fmt, ./task checks, and ./task lint pass.
  • Full ./task test rerun: 13,244 unit tests, 141 skipped, and 26 unrelated shell/Node.js failures from local npm/nvm configuration errors; later stages did not run.

This PR was written by Codex.

@janniklasrose
janniklasrose requested a review from a team as a code owner November 11, 2026 18:12
@janniklasrose
janniklasrose marked this pull request as draft November 11, 2026 18:15
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: f91393d

Run: 43197041980

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 276 15 9:34
💚​ aws-windows-latest-4core-16gb 1 278 13 9:52
💚​ azure linux-2core-8gb 1 275 15 7:59
💚​ azure-windows-latest-4core-16gb 1 277 13 9:13
💚​ gcp linux-2core-8gb 1 276 15 10:47
💚​ gcp-windows-latest-4core-16gb 1 278 13 11:41
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 8 slowest tests (at least 2 minutes):
duration env testname
4:10 gcp-windows-latest-4core-16gb TestAccept
3:55 gcp linux-2core-8gb TestAccept
3:41 aws-windows-latest-4core-16gb TestAccept
3:41 azure-windows-latest-4core-16gb TestAccept
3:20 azure linux-2core-8gb TestAccept
3:12 aws linux-2core-8gb TestAccept
2:05 gcp-windows-latest-4core-16gb TestFsCpDirToDirWithOverwriteFlag/local_to_dbfs
2:02 gcp linux-2core-8gb TestFsCpDirToDirFileNotOverwritten/dbfs_to_dbfs

@janniklasrose janniklasrose changed the title Add a heading to regression test report comments Lead regression report comments with a status heading Nov 12, 2026
@rugpanov
rugpanov removed their request for review November 12, 2026 13:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants